From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbdLUNRB (ORCPT ); Thu, 21 Dec 2017 08:17:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:55364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbdLUNQ4 (ORCPT ); Thu, 21 Dec 2017 08:16:56 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B16C2192D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Thu, 21 Dec 2017 22:16:51 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: David Miller , mingo@kernel.org, ian.mcdonald@jandi.co.nz, vyasevich@gmail.com, stephen@networkplumber.org, peterz@infradead.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com, gerrit@erg.abdn.ac.uk, nhorman@tuxdriver.com, dccp@vger.kernel.org, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, sfr@canb.auug.org.au Subject: Re: [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events Message-Id: <20171221221651.fe8f18d4b8c63b1afdb821f4@kernel.org> In-Reply-To: <20171220221238.2b0a9fa1@vmware.local.home> References: <151374325126.2497.6934744693865165386.stgit@devbox> <20171220.142040.593760128783699712.davem@davemloft.net> <20171220.142424.1214953044518214833.davem@davemloft.net> <20171221113657.f25b2f61eb472579ab32132d@kernel.org> <20171220221238.2b0a9fa1@vmware.local.home> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Dec 2017 22:12:38 -0500 Steven Rostedt wrote: > On Thu, 21 Dec 2017 11:36:57 +0900 > Masami Hiramatsu wrote: > > > On Wed, 20 Dec 2017 14:24:24 -0500 (EST) > > David Miller wrote: > > > > > From: David Miller > > > Date: Wed, 20 Dec 2017 14:20:40 -0500 (EST) > > > > > > > From: Masami Hiramatsu > > > > Date: Wed, 20 Dec 2017 13:14:11 +0900 > > > > > > > >> This series is v4 of the replacement of jprobe usage with trace > > > >> events. This version is rebased on net-next, fixes a build warning > > > >> and moves a temporal variable definition in a block. > > > >> > > > >> Previous version is here; > > > >> https://lkml.org/lkml/2017/12/19/153 > > > >> > > > >> Changes from v3: > > > >> All: Rebased on net-next > > > >> [3/6]: fixes a build warning for i386 by casting pointer unsigned > > > >> long instead of __u64, and moves a temporal variable > > > >> definition in a block. > > > > > > > > Looks good, series applied to net-next, thanks. > > > > > > Actually, this doesn't even compile, so I've reverted: > > > > > > [davem@dhcp-10-15-49-227 net-next]$ make -s -j16 > > > In file included from net/dccp/trace.h:105:0, > > > from net/dccp/proto.c:42: > > > ./include/trace/define_trace.h:89:42: fatal error: ./trace.h: No such file or directory > > > #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) > > > ^ > > > compilation terminated. > > > > Hi David, > > > > Could you share your .config file? I would like to reproduce it. > > When I tried with attached kconfig, I could not reproduce this issue, > > and could run it. > > > > Hi Masami, > > Are you sure you committed everything in this change set? I don't see a > modification of the Makefile to get the trace.h file you created. > Shouldn't there be something like: > > CFLAGS_proto.o := -I$(src) > > in the Makefile? Oops, I didn't do that, but also I had committed all in this changeset. Hmm, strange, because I don't see same issue... At first I will try to reproduce it and try above flags again. Thank you, -- Masami Hiramatsu