public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: shrikant.maurya@techveda.org
Cc: ok@artecdesign.ee, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, Suniel Mahesh <sunil.m@techveda.org>,
	Raghu Bharadwaj <raghu@techveda.org>,
	Karthik Tummala <karthik@techveda.org>
Subject: Re: [PATCH] drivers: usb: host: Fix GFP_KERNEL in spinlock context
Date: Fri, 22 Dec 2017 08:13:15 +0100	[thread overview]
Message-ID: <20171222071315.GA10784@kroah.com> (raw)
In-Reply-To: <1513921764-17246-1-git-send-email-shrikant.maurya@techveda.org>

On Fri, Dec 22, 2017 at 11:19:24AM +0530, shrikant.maurya@techveda.org wrote:
> From: Shrikant Maurya <shrikant.maurya@techveda.org>
> 
> As reported by Jia-Ju Bai (https://lkml.org/lkml/2017/12/11/872):
> API's are using GFP_KERNEL to allocate memory, which may sleep.
> To ensure atomicity such allocations must be avoided in critical
> sections under spinlock.
> Fixed by moving part of the code which is using GFP_KERNEL for
> memory allocation out of spinlock.
> 
> Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> Signed-off-by: Shrikant Maurya <shrikant.maurya@techveda.org>
> Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
> Signed-off-by: Raghu Bharadwaj <raghu@techveda.org>
> Signed-off-by: Karthik Tummala <karthik@techveda.org>
> ---
> Note:
> - trace of device_init_wakeup() leads to creation of a struct
>   wakeup_source object and addition of the object to the list
>   of wakeup sources. While allocating wakeup_source object, API
>   is using GFP_KERNEL. This particular section is removed out of
>   spinlock.
> - Changeset was compile tested and built(ARCH=arm) on linux-next
>   (latest).
> - No build issues reported.
> - Changeset was not tested on hardware.

No one was able to test on the hardware itself?  Ideally I'd like to see
that happen to verify nothing breaks here.  No one has this chip on any
devices?

thanks,

greg k-h

  reply	other threads:[~2017-12-22  7:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22  5:49 [PATCH] drivers: usb: host: Fix GFP_KERNEL in spinlock context shrikant.maurya
2017-12-22  7:13 ` Greg KH [this message]
2017-12-22  7:50   ` Shrikant Maurya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222071315.GA10784@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=karthik@techveda.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ok@artecdesign.ee \
    --cc=raghu@techveda.org \
    --cc=shrikant.maurya@techveda.org \
    --cc=sunil.m@techveda.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox