From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752347AbdLVHPX (ORCPT ); Fri, 22 Dec 2017 02:15:23 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbdLVHPV (ORCPT ); Fri, 22 Dec 2017 02:15:21 -0500 Date: Fri, 22 Dec 2017 08:15:22 +0100 From: Greg KH To: Vinod Koul Cc: Colin King , Sanyog Kale , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] soundwire: intel: fix missing assignment to ret Message-ID: <20171222071522.GA11094@kroah.com> References: <20171221233210.8821-1-colin.king@canonical.com> <20171222033148.GN18649@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171222033148.GN18649@localhost> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 22, 2017 at 09:01:49AM +0530, Vinod Koul wrote: > On Thu, Dec 21, 2017 at 11:32:10PM +0000, Colin King wrote: > > From: Colin Ian King > > > > Currently the return status ret is being checked but it has not been > > updated since the previous check on ret. It appears that assignment of > > ret from return status of the call to sdw_cdns_enable_interrupt was > > accidentally ommited. Fix this. > > Thanks Colin, this looks good to me. > > Greg, we have this and another patch from Colin, both lgtm. > > Would you like me to collect these and send to you before merge cycle or > apply directly? Please collect and then send on, as it is not in my queue at all. thanks, greg k-h