From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: nsekhar@ti.com, khilman@kernel.org, kaloz@openwrt.org,
khalasa@piap.pl, aaro.koskinen@iki.fi, tony@atomide.com,
jason@lakedaemon.net, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com,
gregory.clement@free-electrons.com, daniel@zonque.org,
haojian.zhuang@gmail.com, robert.jarzmik@free.fr,
marek.vasut@gmail.com, slapin@ossfans.org, jic23@cam.ac.uk,
kgene@kernel.org, krzk@kernel.org, ralf@linux-mips.org,
ysato@users.sourceforge.jp, dalias@libc.org, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] constify gpio_led
Date: Sat, 23 Dec 2017 10:13:21 +0000 [thread overview]
Message-ID: <20171223101321.GQ10595@n2100.armlinux.org.uk> (raw)
In-Reply-To: <cover.1513756005.git.arvind.yadav.cs@gmail.com>
On Wed, Dec 20, 2017 at 02:17:41PM +0530, Arvind Yadav wrote:
> gpio_led are not supposed to change at runtime.
> struct gpio_led_platform_data working with const gpio_led
> provided by <linux/leds.h>. So mark the non-const structs
> as const.
Marking the structs as const is fine, but marking them __initconst is
not. The GPIO LED driver can be built as a module, which means it can
be loaded after the init sections have gone away. If that happens,
then we de-reference the pointer to memory that has been freed.
Please re-spin your patch set without the __initconst marking.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-12-23 10:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 8:47 [PATCH 00/11] constify gpio_led Arvind Yadav
2017-12-20 8:47 ` [PATCH 01/11] MIPS: Alchemy: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 02/11] MIPS: AR7: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 03/11] MIPS: TXX9: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 04/11] x86: geode: " Arvind Yadav
2017-12-23 7:50 ` kbuild test robot
2017-12-20 8:47 ` [PATCH 05/11] sh: mach-rsk: rsk7203: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 06/11] ARM: davinci: " Arvind Yadav
2017-12-23 10:01 ` Sekhar Nori
2017-12-20 8:47 ` [PATCH 07/11] ARM: ixp4xx: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 08/11] ARM: OMAP1: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 09/11] ARM: orion5x: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 10/11] ARM: s3c24xx: " Arvind Yadav
2017-12-20 8:47 ` [PATCH 11/11] ARM: pxa: " Arvind Yadav
2017-12-24 17:54 ` kbuild test robot
2017-12-25 13:04 ` arvindY
2017-12-23 10:13 ` Russell King - ARM Linux [this message]
2017-12-25 13:07 ` [PATCH 00/11] " arvindY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171223101321.GQ10595@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=aaro.koskinen@iki.fi \
--cc=andrew@lunn.ch \
--cc=arvind.yadav.cs@gmail.com \
--cc=dalias@libc.org \
--cc=daniel@zonque.org \
--cc=gregory.clement@free-electrons.com \
--cc=haojian.zhuang@gmail.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jic23@cam.ac.uk \
--cc=kaloz@openwrt.org \
--cc=kgene@kernel.org \
--cc=khalasa@piap.pl \
--cc=khilman@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mingo@redhat.com \
--cc=nsekhar@ti.com \
--cc=ralf@linux-mips.org \
--cc=robert.jarzmik@free.fr \
--cc=sebastian.hesselbarth@gmail.com \
--cc=slapin@ossfans.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox