* [PATCH] uuid: cleanup <uapi/linux/uuid.h>
@ 2017-12-25 17:11 Alexey Dobriyan
2017-12-29 16:39 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2017-12-25 17:11 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
Exported header doesn't use anything from <linux/string.h>,
it is <linux/uuid.h> which uses memcmp().
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/linux/uuid.h | 1 +
include/uapi/linux/uuid.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
--- a/include/linux/uuid.h
+++ b/include/linux/uuid.h
@@ -17,6 +17,7 @@
#define _LINUX_UUID_H_
#include <uapi/linux/uuid.h>
+#include <linux/string.h>
#define UUID_SIZE 16
--- a/include/uapi/linux/uuid.h
+++ b/include/uapi/linux/uuid.h
@@ -19,7 +19,6 @@
#define _UAPI_LINUX_UUID_H_
#include <linux/types.h>
-#include <linux/string.h>
typedef struct {
__u8 b[16];
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] uuid: cleanup <uapi/linux/uuid.h>
2017-12-25 17:11 [PATCH] uuid: cleanup <uapi/linux/uuid.h> Alexey Dobriyan
@ 2017-12-29 16:39 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2017-12-29 16:39 UTC (permalink / raw)
To: Alexey Dobriyan, Christoph Hellwig
Cc: Andrew Morton, Linux Kernel Mailing List
On Mon, Dec 25, 2017 at 7:11 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Exported header doesn't use anything from <linux/string.h>,
> it is <linux/uuid.h> which uses memcmp().
>
+Cc UUID maintainer(s)
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
(If I didn't miss anything, that looks fine)
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> include/linux/uuid.h | 1 +
> include/uapi/linux/uuid.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> --- a/include/linux/uuid.h
> +++ b/include/linux/uuid.h
> @@ -17,6 +17,7 @@
> #define _LINUX_UUID_H_
>
> #include <uapi/linux/uuid.h>
> +#include <linux/string.h>
>
> #define UUID_SIZE 16
>
> --- a/include/uapi/linux/uuid.h
> +++ b/include/uapi/linux/uuid.h
> @@ -19,7 +19,6 @@
> #define _UAPI_LINUX_UUID_H_
>
> #include <linux/types.h>
> -#include <linux/string.h>
>
> typedef struct {
> __u8 b[16];
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-29 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-25 17:11 [PATCH] uuid: cleanup <uapi/linux/uuid.h> Alexey Dobriyan
2017-12-29 16:39 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox