From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbdLYVq7 (ORCPT ); Mon, 25 Dec 2017 16:46:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752841AbdLYVq4 (ORCPT ); Mon, 25 Dec 2017 16:46:56 -0500 Date: Mon, 25 Dec 2017 22:46:46 +0100 From: Jiri Olsa To: Aaron Tomlin Cc: acme@kernel.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH/RFC] perf report: Add option to change offset format when address is specified as a sort_key Message-ID: <20171225214646.GC25478@krava> References: <20171215153510.14499-1-atomlin@redhat.com> <20171222235941.GA22304@krava> <20171224182315.xhz5n2z6dkibthzc@atomlin.usersys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171224182315.xhz5n2z6dkibthzc@atomlin.usersys.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 25 Dec 2017 21:46:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 24, 2017 at 06:23:15PM +0000, Aaron Tomlin wrote: > On Sat 2017-12-23 00:59 +0100, Jiri Olsa wrote: > [ ... ] > > not sure we've already discussed that, but this could be default? > > Probably it is best to keep the default behaviour. > > I'd prefer a hexadecimal address offset, as the default, however perhaps > someone is happy with the current default (decimal). Arnaldo? > > > if not, I think the hex option should be part of -g option arg, maybe like: > > Does it have to be? > > > -g graph,callee,xaddress > > Not sure - adding another sort_key seems odd to me. it's not sort key, it's -g option key.. but if we go for default there's no need.. let's see ;-) > > But if you insist, perhaps address[=hex] would be cleaner? but yes, that looks better to me jirka