From: Stephen Boyd <sboyd@codeaurora.org>
To: sean.wang@mediatek.com
Cc: mturquette@baylibre.com, matthias.bgg@gmail.com,
jdelvare@suse.de, jamesjj.liao@mediatek.com,
weiyi.lu@mediatek.com, kevin-cw.chen@mediatek.com,
shunli.wang@mediatek.com, chen.zhong@mediatek.com, arnd@arndb.de,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: mediatek: remove superfluous line including linux/clk-provider.h
Date: Tue, 26 Dec 2017 17:15:07 -0800 [thread overview]
Message-ID: <20171227011507.GR7997@codeaurora.org> (raw)
In-Reply-To: <96d2fcd536d75dbbfde0aa0ad0797e80da89117b.1514191770.git.sean.wang@mediatek.com>
On 12/25, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> clk-mtk.h has already included linux/clk-provider.h inside, so remove
> the superfluous line including linux/clk-provider.h from these files which
> also included clk-mtk.h.
>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Cc: Jean Delvare <jdelvare@suse.de>
> ---
Please don't do this. If anything, I would remove as many
includes from clk-mtk.h as possible and forward declare the
structures used in there so there isn't any header dependency.
Then it becomes clear which C files are clk-provider drivers
almost immediately because we have the include in the driver, and
we also avoid any header dependency chains where we must include
some header file if we want to get another header file's
definitions.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-12-27 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 9:05 [PATCH] clk: mediatek: remove superfluous line including linux/clk-provider.h sean.wang
2017-12-27 1:15 ` Stephen Boyd [this message]
2017-12-27 4:01 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227011507.GR7997@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=chen.zhong@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=jdelvare@suse.de \
--cc=kevin-cw.chen@mediatek.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sean.wang@mediatek.com \
--cc=shunli.wang@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox