From: Bartosz Golaszewski <brgl@bgdev.pl>
To: linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH] eeprom: at24: check the return value of nvmem_unregister()
Date: Wed, 27 Dec 2017 15:10:38 +0100 [thread overview]
Message-ID: <20171227141038.31646-1-brgl@bgdev.pl> (raw)
This function can fail with -EBUSY, but we don't check its return
value in at24_remove(). Bail-out of remove() if nvmem_unregister()
doesn't succeed.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
drivers/misc/eeprom/at24.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index e79833d62284..fb21e1c45115 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -684,11 +684,13 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
static int at24_remove(struct i2c_client *client)
{
struct at24_data *at24;
- int i;
+ int i, ret;
at24 = i2c_get_clientdata(client);
- nvmem_unregister(at24->nvmem);
+ ret = nvmem_unregister(at24->nvmem);
+ if (ret)
+ return ret;
for (i = 1; i < at24->num_addresses; i++)
i2c_unregister_device(at24->client[i].client);
--
2.15.1
next reply other threads:[~2017-12-27 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 14:10 Bartosz Golaszewski [this message]
2017-12-28 11:28 ` [PATCH] eeprom: at24: check the return value of nvmem_unregister() Johan Hovold
2017-12-28 21:42 ` Bartosz Golaszewski
2017-12-28 23:05 ` Heiner Kallweit
2017-12-29 9:48 ` Johan Hovold
2018-01-02 11:17 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227141038.31646-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox