* [PATCH] dt: bindings: as3645a: Fix the example node
@ 2017-12-05 13:36 Dan Murphy
2017-12-05 20:03 ` Dan Murphy
2017-12-06 21:52 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Dan Murphy @ 2017-12-05 13:36 UTC (permalink / raw)
To: robh+dt, mark.rutland, rpurdie, jacek.anaszewski, pavel
Cc: devicetree, linux-kernel, linux-leds, Dan Murphy
Fix the address-cells and size-cells example node
to reflect to the correct representation.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..8a49ccfec29b 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,8 +59,8 @@ Example
=======
as3645a@30 {
- #address-cells: 1
- #size-cells: 0
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0x30>;
compatible = "ams,as3645a";
flash@0 {
--
2.15.0.124.g7668cbc60
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt: bindings: as3645a: Fix the example node
2017-12-05 13:36 [PATCH] dt: bindings: as3645a: Fix the example node Dan Murphy
@ 2017-12-05 20:03 ` Dan Murphy
2017-12-06 21:52 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Dan Murphy @ 2017-12-05 20:03 UTC (permalink / raw)
To: robh+dt, mark.rutland, rpurdie, jacek.anaszewski, pavel,
sakari.ailus
Cc: devicetree, linux-kernel, linux-leds
+Sakari driver maintainer
On 12/05/2017 07:36 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..8a49ccfec29b 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,8 +59,8 @@ Example
> =======
>
> as3645a@30 {
> - #address-cells: 1
> - #size-cells: 0
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <0x30>;
> compatible = "ams,as3645a";
> flash@0 {
>
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt: bindings: as3645a: Fix the example node
2017-12-05 13:36 [PATCH] dt: bindings: as3645a: Fix the example node Dan Murphy
2017-12-05 20:03 ` Dan Murphy
@ 2017-12-06 21:52 ` Rob Herring
2017-12-06 22:32 ` Dan Murphy
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2017-12-06 21:52 UTC (permalink / raw)
To: Dan Murphy
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..8a49ccfec29b 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,8 +59,8 @@ Example
> =======
>
> as3645a@30 {
> - #address-cells: 1
> - #size-cells: 0
> + #address-cells = <1>;
> + #size-cells = <0>;
> reg = <0x30>;
> compatible = "ams,as3645a";
Convention is also we put compatible first.
> flash@0 {
> --
> 2.15.0.124.g7668cbc60
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt: bindings: as3645a: Fix the example node
2017-12-06 21:52 ` Rob Herring
@ 2017-12-06 22:32 ` Dan Murphy
2017-12-07 15:42 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Dan Murphy @ 2017-12-06 22:32 UTC (permalink / raw)
To: Rob Herring
Cc: mark.rutland, rpurdie, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds
Rob
On 12/06/2017 03:52 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>> Fix the address-cells and size-cells example node
>> to reflect to the correct representation.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> index fdc40e354a64..8a49ccfec29b 100644
>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> @@ -59,8 +59,8 @@ Example
>> =======
>>
>> as3645a@30 {
>> - #address-cells: 1
>> - #size-cells: 0
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> reg = <0x30>;
>> compatible = "ams,as3645a";
>
> Convention is also we put compatible first.
>
OK I will move that too for v2.
Can that be in the same patch or do you want a separate patch?
Dan
>> flash@0 {
>> --
>> 2.15.0.124.g7668cbc60
>>
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt: bindings: as3645a: Fix the example node
2017-12-06 22:32 ` Dan Murphy
@ 2017-12-07 15:42 ` Rob Herring
2017-12-27 21:19 ` Pavel Machek
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2017-12-07 15:42 UTC (permalink / raw)
To: Dan Murphy
Cc: Mark Rutland, Richard Purdie, Jacek Anaszewski, Pavel Machek,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux LED Subsystem
On Wed, Dec 6, 2017 at 4:32 PM, Dan Murphy <dmurphy@ti.com> wrote:
> Rob
>
> On 12/06/2017 03:52 PM, Rob Herring wrote:
>> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>>> Fix the address-cells and size-cells example node
>>> to reflect to the correct representation.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> ---
>>> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> index fdc40e354a64..8a49ccfec29b 100644
>>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> @@ -59,8 +59,8 @@ Example
>>> =======
>>>
>>> as3645a@30 {
>>> - #address-cells: 1
>>> - #size-cells: 0
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> reg = <0x30>;
>>> compatible = "ams,as3645a";
>>
>> Convention is also we put compatible first.
>>
>
> OK I will move that too for v2.
>
> Can that be in the same patch or do you want a separate patch?
Same patch is fine.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt: bindings: as3645a: Fix the example node
2017-12-07 15:42 ` Rob Herring
@ 2017-12-27 21:19 ` Pavel Machek
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2017-12-27 21:19 UTC (permalink / raw)
To: Rob Herring
Cc: Dan Murphy, Mark Rutland, Richard Purdie, Jacek Anaszewski,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux LED Subsystem
[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]
On Thu 2017-12-07 09:42:29, Rob Herring wrote:
> On Wed, Dec 6, 2017 at 4:32 PM, Dan Murphy <dmurphy@ti.com> wrote:
> > Rob
> >
> > On 12/06/2017 03:52 PM, Rob Herring wrote:
> >> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
> >>> Fix the address-cells and size-cells example node
> >>> to reflect to the correct representation.
> >>>
> >>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> >>> ---
> >>> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> index fdc40e354a64..8a49ccfec29b 100644
> >>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> @@ -59,8 +59,8 @@ Example
> >>> =======
> >>>
> >>> as3645a@30 {
> >>> - #address-cells: 1
> >>> - #size-cells: 0
> >>> + #address-cells = <1>;
> >>> + #size-cells = <0>;
> >>> reg = <0x30>;
> >>> compatible = "ams,as3645a";
> >>
> >> Convention is also we put compatible first.
> >>
> >
> > OK I will move that too for v2.
> >
> > Can that be in the same patch or do you want a separate patch?
>
> Same patch is fine.
For fixed patch:
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-27 21:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05 13:36 [PATCH] dt: bindings: as3645a: Fix the example node Dan Murphy
2017-12-05 20:03 ` Dan Murphy
2017-12-06 21:52 ` Rob Herring
2017-12-06 22:32 ` Dan Murphy
2017-12-07 15:42 ` Rob Herring
2017-12-27 21:19 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox