From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbdL0XNw (ORCPT ); Wed, 27 Dec 2017 18:13:52 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:44594 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122AbdL0XNt (ORCPT ); Wed, 27 Dec 2017 18:13:49 -0500 X-Google-Smtp-Source: ACJfBovNC5qjYpFDHABn2PHwVdbRc3Hw6GB4Sj6ai5qOmdPb6eL04M7fbtaConAx38Br7fidkyAWMg== Date: Wed, 27 Dec 2017 15:13:48 -0800 From: Bjorn Andersson To: SF Markus Elfring Cc: linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Linus Walleij , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe() Message-ID: <20171227231348.GG478@tuxbook> References: <0d5eae19-c8f9-3280-e68e-419646535512@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d5eae19-c8f9-3280-e68e-419646535512@users.sourceforge.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 27 Dec 13:10 PST 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 27 Dec 2017 22:04:22 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thank's Markus, Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 7a960590ecaa..495432f3341b 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -898,10 +898,9 @@ int msm_pinctrl_probe(struct platform_device *pdev, > int ret; > > pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > - if (!pctrl) { > - dev_err(&pdev->dev, "Can't allocate msm_pinctrl\n"); > + if (!pctrl) > return -ENOMEM; > - } > + > pctrl->dev = &pdev->dev; > pctrl->soc = soc_data; > pctrl->chip = msm_gpio_template; > -- > 2.15.1 >