* [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()
@ 2017-12-27 21:10 SF Markus Elfring
2017-12-27 23:13 ` Bjorn Andersson
2017-12-28 12:41 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2017-12-27 21:10 UTC (permalink / raw)
To: linux-gpio, linux-arm-msm, Bjorn Andersson, Linus Walleij
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 27 Dec 2017 22:04:22 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 7a960590ecaa..495432f3341b 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -898,10 +898,9 @@ int msm_pinctrl_probe(struct platform_device *pdev,
int ret;
pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL);
- if (!pctrl) {
- dev_err(&pdev->dev, "Can't allocate msm_pinctrl\n");
+ if (!pctrl)
return -ENOMEM;
- }
+
pctrl->dev = &pdev->dev;
pctrl->soc = soc_data;
pctrl->chip = msm_gpio_template;
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()
2017-12-27 21:10 [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe() SF Markus Elfring
@ 2017-12-27 23:13 ` Bjorn Andersson
2017-12-28 12:41 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2017-12-27 23:13 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-gpio, linux-arm-msm, Linus Walleij, LKML, kernel-janitors
On Wed 27 Dec 13:10 PST 2017, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 27 Dec 2017 22:04:22 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Thank's Markus,
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 7a960590ecaa..495432f3341b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -898,10 +898,9 @@ int msm_pinctrl_probe(struct platform_device *pdev,
> int ret;
>
> pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL);
> - if (!pctrl) {
> - dev_err(&pdev->dev, "Can't allocate msm_pinctrl\n");
> + if (!pctrl)
> return -ENOMEM;
> - }
> +
> pctrl->dev = &pdev->dev;
> pctrl->soc = soc_data;
> pctrl->chip = msm_gpio_template;
> --
> 2.15.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe()
2017-12-27 21:10 [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe() SF Markus Elfring
2017-12-27 23:13 ` Bjorn Andersson
@ 2017-12-28 12:41 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-12-28 12:41 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-gpio, linux-arm-msm, Bjorn Andersson, LKML, kernel-janitors
On Wed, Dec 27, 2017 at 10:10 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 27 Dec 2017 22:04:22 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch applied with Björn's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-28 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-27 21:10 [PATCH] pinctrl: msm: Delete an error message for a failed memory allocation in msm_pinctrl_probe() SF Markus Elfring
2017-12-27 23:13 ` Bjorn Andersson
2017-12-28 12:41 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox