From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752777AbdL1AAH (ORCPT <rfc822;w@1wt.eu>);
        Wed, 27 Dec 2017 19:00:07 -0500
Received: from LGEAMRELO11.lge.com ([156.147.23.51]:45313 "EHLO
        lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752670AbdL1AAG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 27 Dec 2017 19:00:06 -0500
X-Original-SENDERIP: 156.147.1.125
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 10.177.220.163
X-Original-MAILFROM: minchan@kernel.org
Date: Thu, 28 Dec 2017 09:00:04 +0900
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Gopi Sai Teja <gopi.st@samsung.com>, ngupta@vflare.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org, v.narang@samsung.com,
        pankaj.m@samsung.com, a.sahrawat@samsung.com, prakash.a@samsung.com,
        himanshu.sh@samsung.com, lalit.mohan@samsung.com
Subject: Re: [PATCH v2] zram: better utilization of zram swap space
Message-ID: <20171228000004.GB10532@bbox>
References: <CGME20171222103443epcas5p41f45e1a99146aac89edd63f76a3eb62a@epcas5p4.samsung.com>
 <1513938606-17735-1-git-send-email-gopi.st@samsung.com>
 <20171227062946.GA11295@bgram>
 <20171227071056.GA471@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171227071056.GA471@jagdpanzerIV>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 27, 2017 at 04:10:56PM +0900, Sergey Senozhatsky wrote:
> On (12/27/17 15:29), Minchan Kim wrote:
> > On Fri, Dec 22, 2017 at 04:00:06PM +0530, Gopi Sai Teja wrote:
> > > 75% of the PAGE_SIZE is not a correct threshold to store uncompressed
> > 
> > Please describe it in detail that why current threshold is bad in that
> > memory efficiency point of view.
> > 
> > > pages in zs_page as this must be changed if the maximum pages stored
> > > in zspage changes. Instead using zs classes, we can set the correct
> > 
> > Also, let's include the pharase Sergey pointed out in this description.
> > 
> > It's not a good idea that zram need to know allocator's implementation
> > with harded value like 75%.
> 
> so I don't like that, basically, my work and my findings are
> now submitted by someone else without even crediting my work.
> not to mention that I like my commit message much better.
> 
> 	-ss

Gopi Sai Teja, please discuss with Sergey about patch credit.