* [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses
@ 2017-12-28 10:24 Elad Wexler
2018-01-08 15:07 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Elad Wexler @ 2017-12-28 10:24 UTC (permalink / raw)
To: gilad, gregkh; +Cc: linux-crypto, driverdev-devel, devel, linux-kernel
Fixed a coding style issue
Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
---
drivers/staging/ccree/ssi_hash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c
index 2035835..8d56fa7 100644
--- a/drivers/staging/ccree/ssi_hash.c
+++ b/drivers/staging/ccree/ssi_hash.c
@@ -2280,8 +2280,8 @@ int ssi_hash_alloc(struct ssi_drvdata *drvdata)
&hash_handle->hash_list);
}
- if ((hw_mode == DRV_CIPHER_XCBC_MAC) ||
- (hw_mode == DRV_CIPHER_CMAC))
+ if (hw_mode == DRV_CIPHER_XCBC_MAC ||
+ hw_mode == DRV_CIPHER_CMAC)
continue;
/* register hash version */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses
2017-12-28 10:24 [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses Elad Wexler
@ 2018-01-08 15:07 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-01-08 15:07 UTC (permalink / raw)
To: Elad Wexler; +Cc: gilad, devel, driverdev-devel, linux-crypto, linux-kernel
On Thu, Dec 28, 2017 at 12:24:17PM +0200, Elad Wexler wrote:
> Fixed a coding style issue
>
> Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
> ---
> drivers/staging/ccree/ssi_hash.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Why did you send this twice?
> diff --git a/drivers/staging/ccree/ssi_hash.c b/drivers/staging/ccree/ssi_hash.c
> index 2035835..8d56fa7 100644
> --- a/drivers/staging/ccree/ssi_hash.c
> +++ b/drivers/staging/ccree/ssi_hash.c
> @@ -2280,8 +2280,8 @@ int ssi_hash_alloc(struct ssi_drvdata *drvdata)
> &hash_handle->hash_list);
> }
>
> - if ((hw_mode == DRV_CIPHER_XCBC_MAC) ||
> - (hw_mode == DRV_CIPHER_CMAC))
> + if (hw_mode == DRV_CIPHER_XCBC_MAC ||
> + hw_mode == DRV_CIPHER_CMAC)
No, now I have to go look up if == or || comes in which order. Ick,
just leave it as-is please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-08 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-28 10:24 [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses Elad Wexler
2018-01-08 15:07 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox