public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Nick Desaulniers <nick.desaulniers@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jiri Slaby <jslaby@suse.cz>,
	der.herr@hofr.at
Subject: Re: [PATCH] objtool: Fix clang enum conversion warning
Date: Thu, 28 Dec 2017 13:09:45 +0100	[thread overview]
Message-ID: <20171228120945.qppd7o7jpchbpxuu@gmail.com> (raw)
In-Reply-To: <20171228051207.zlbdyuwwaq52ff5q@treble>


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Wed, Dec 27, 2017 at 10:42:45PM -0500, Nick Desaulniers wrote:
> > On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote:
> > >> Assuming that the authorship of this one-line change does not matter, as it
> > >> is largely suggested by the clang compiler anyway, and we want to move the
> > >> change forward, we should decide on which of three patches to move
> > >> forward. I can give my Reviewed-by and Tested-by to any of them.
> > 
> > I suppose Ingo would take the first and accumulate Reviewed-By tags.
> > I don't particularly care about authorship (please just fix the bug).
> > 
> > > The patch from Lukas was the first one I received, so that's the one I
> > > used.  I rewrote the commit msg for clarity and added my SOB and sent it
> > > to Ingo for merging.
> > 
> > I think you should have kept Nicholas Mc Guire's Reviewed by tag?
> > Maybe Ingo can re-add his and mine when merging?
> 
> Yes, sorry, I missed that one.
> 
> Ingo, can you please add the following?
> 
> Reviewed-by: Nicholas Mc Guire <der.herr@hofr.at>
> Reviewed-by: Nick Desaulniers <nick.desaulniers@gmail.com>

Sure, done!

Thanks,

	Ingo

  reply	other threads:[~2017-12-28 12:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-26 21:27 [PATCH] objtool: Fix clang enum conversion warning Josh Poimboeuf
2017-12-27  0:35 ` Nick Desaulniers
2017-12-27 12:34   ` Lukas Bulwahn
2017-12-27 17:38     ` Josh Poimboeuf
2017-12-28  3:42       ` Nick Desaulniers
2017-12-28  5:12         ` Josh Poimboeuf
2017-12-28 12:09           ` Ingo Molnar [this message]
2017-12-28  8:18       ` Lukas Bulwahn
2017-12-28 15:37 ` [tip:core/urgent] objtool: Fix Clang " tip-bot for Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171228120945.qppd7o7jpchbpxuu@gmail.com \
    --to=mingo@kernel.org \
    --cc=der.herr@hofr.at \
    --cc=jpoimboe@redhat.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=nick.desaulniers@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox