From: Jonathan Cameron <jic23@kernel.org>
To: Ji-Hun Kim <jihuun.k@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: iio: remove unnecessary parentheses
Date: Fri, 29 Dec 2017 12:04:49 +0000 [thread overview]
Message-ID: <20171229120449.449bfb6a@archlinux> (raw)
In-Reply-To: <20171228024714.GA3110@MacBook-Air>
On Wed, 27 Dec 2017 18:47:18 -0800
Ji-Hun Kim <jihuun.k@gmail.com> wrote:
> Clean up checkpatch warning:
> CHECK: Unnecessary parentheses around 'st->devid != ID_AD7195'
>
> Signed-off-by: Ji-Hun Kim <jihuun.k@gmail.com>
I've personally never really cared about this particular one as
removing the brackets doesn't make the code easier to read.
However, it is worthwhile to suppress checkpatch warnings so
we can see the ones that matter.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index cadfb96..f015955 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -271,7 +271,7 @@ static int ad7192_setup(struct ad7192_state *st,
> if (pdata->sinc3_en)
> st->mode |= AD7192_MODE_SINC3;
>
> - if (pdata->refin2_en && (st->devid != ID_AD7195))
> + if (pdata->refin2_en && st->devid != ID_AD7195)
> st->conf |= AD7192_CONF_REFSEL;
>
> if (pdata->chop_en) {
prev parent reply other threads:[~2017-12-29 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 2:47 [PATCH 1/2] staging: iio: remove unnecessary parentheses Ji-Hun Kim
2017-12-29 12:04 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229120449.449bfb6a@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=jihuun.k@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox