* [PATCH 1/2] staging: iio: remove unnecessary parentheses
@ 2017-12-28 2:47 Ji-Hun Kim
2017-12-29 12:04 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Ji-Hun Kim @ 2017-12-28 2:47 UTC (permalink / raw)
To: lars
Cc: Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh, linux-iio,
device-drivers-devel, devel, linux-kernel
Clean up checkpatch warning:
CHECK: Unnecessary parentheses around 'st->devid != ID_AD7195'
Signed-off-by: Ji-Hun Kim <jihuun.k@gmail.com>
---
drivers/staging/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index cadfb96..f015955 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -271,7 +271,7 @@ static int ad7192_setup(struct ad7192_state *st,
if (pdata->sinc3_en)
st->mode |= AD7192_MODE_SINC3;
- if (pdata->refin2_en && (st->devid != ID_AD7195))
+ if (pdata->refin2_en && st->devid != ID_AD7195)
st->conf |= AD7192_CONF_REFSEL;
if (pdata->chop_en) {
--
2.10.1 (Apple Git-78)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/2] staging: iio: remove unnecessary parentheses
2017-12-28 2:47 [PATCH 1/2] staging: iio: remove unnecessary parentheses Ji-Hun Kim
@ 2017-12-29 12:04 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-12-29 12:04 UTC (permalink / raw)
To: Ji-Hun Kim
Cc: lars, Michael.Hennerich, knaack.h, pmeerw, gregkh, linux-iio,
device-drivers-devel, devel, linux-kernel
On Wed, 27 Dec 2017 18:47:18 -0800
Ji-Hun Kim <jihuun.k@gmail.com> wrote:
> Clean up checkpatch warning:
> CHECK: Unnecessary parentheses around 'st->devid != ID_AD7195'
>
> Signed-off-by: Ji-Hun Kim <jihuun.k@gmail.com>
I've personally never really cared about this particular one as
removing the brackets doesn't make the code easier to read.
However, it is worthwhile to suppress checkpatch warnings so
we can see the ones that matter.
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index cadfb96..f015955 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -271,7 +271,7 @@ static int ad7192_setup(struct ad7192_state *st,
> if (pdata->sinc3_en)
> st->mode |= AD7192_MODE_SINC3;
>
> - if (pdata->refin2_en && (st->devid != ID_AD7195))
> + if (pdata->refin2_en && st->devid != ID_AD7195)
> st->conf |= AD7192_CONF_REFSEL;
>
> if (pdata->chop_en) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-29 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-28 2:47 [PATCH 1/2] staging: iio: remove unnecessary parentheses Ji-Hun Kim
2017-12-29 12:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox