From: Jonathan Cameron <jic23@kernel.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: add kernel-doc '@owner'
Date: Fri, 29 Dec 2017 17:36:40 +0000 [thread overview]
Message-ID: <20171229173640.5fd6e649@archlinux> (raw)
In-Reply-To: <1513664270-29523-1-git-send-email-me@tobin.cc>
On Tue, 19 Dec 2017 17:17:50 +1100
"Tobin C. Harding" <me@tobin.cc> wrote:
> When building kernel documentation sphinx emits the following warning
>
> warning: No description found for parameter 'owner'
>
> Add description for struct member 'owner'.
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
> ---
>
> I couldn't work out what DRIVER/INTERN were for so I took a guess.
Try the other one ;)
They refer to whether the driver should be directly accessing the
field or not. In the case of owner they shouldn't be so it is INTERN.
Were I writing the subsystem from scratch again I'd probably make the
separation of the two cleaner, but there we are.
Jonathan
>
> include/linux/iio/trigger.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 7d5e44518379..d884b5099cd0 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -43,6 +43,7 @@ struct iio_trigger_ops {
> /**
> * struct iio_trigger - industrial I/O trigger device
> * @ops: [DRIVER] operations structure
> + * @owner: [DRIVER] owner of this driver module
> * @id: [INTERN] unique id number
> * @name: [DRIVER] unique name
> * @dev: [DRIVER] associated device (if relevant)
next prev parent reply other threads:[~2017-12-29 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 6:17 [PATCH] iio: add kernel-doc '@owner' Tobin C. Harding
2017-12-29 17:36 ` Jonathan Cameron [this message]
2017-12-30 9:58 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229173640.5fd6e649@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox