From: Jonathan Cameron <jic23@kernel.org>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: <linux-iio@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Maciej Purski <m.purski@samsung.com>,
<linux-kernel@vger.kernel.org>, "Andrew F . Davis" <afd@ti.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>
Subject: Re: [PATCH v2 1/7] iio: adc: ina2xx: Remove bogus cast for data argument
Date: Fri, 29 Dec 2017 17:46:02 +0000 [thread overview]
Message-ID: <20171229174602.26e7d62d@archlinux> (raw)
In-Reply-To: <b59a9f59-da42-41b6-926b-50fb5b7909c3@rwthex-w2-a.rwth-ad.de>
On Thu, 21 Dec 2017 19:31:32 +0100
Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:
> iio_push_to_buffers_with_timestamp expects a void pointer, so the cast
> is both unnecessary and misleading.
>
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Hi Stefan,
I applied the first few patches the first time around.
Please drop them from new versions - if nothing else
if confuses me ;)
> ---
>
> Changes in v2: None
>
> drivers/iio/adc/ina2xx-adc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index ddf878163bf9..3195f8754c3b 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -767,8 +767,7 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
>
> time_b = iio_get_time_ns(indio_dev);
>
> - iio_push_to_buffers_with_timestamp(indio_dev,
> - (unsigned int *)data, time_a);
> + iio_push_to_buffers_with_timestamp(indio_dev, data, time_a);
>
> return (unsigned long)(time_b - time_a) / 1000;
> };
next prev parent reply other threads:[~2017-12-29 17:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171221183138.361-1-stefan.bruens@rwth-aachen.de>
2017-12-21 18:31 ` [PATCH v2 1/7] iio: adc: ina2xx: Remove bogus cast for data argument Stefan Brüns
2017-12-29 17:46 ` Jonathan Cameron [this message]
2017-12-21 18:31 ` [PATCH v2 2/7] iio: adc: ina2xx: Clarify size requirement for data buffer Stefan Brüns
2017-12-21 18:31 ` [PATCH v2 3/7] iio: adc: ina2xx: Remove unneeded dummy read to clear CNVR flag Stefan Brüns
2017-12-21 18:31 ` [PATCH v2 4/7] iio: adc: ina2xx: Do not udelay for several seconds Stefan Brüns
2017-12-21 18:31 ` [PATCH v2 5/7] iio: adc: ina2xx: Use a monotonic clock for delay calculation Stefan Brüns
2017-12-29 17:48 ` Jonathan Cameron
2017-12-31 19:55 ` [PATCH v3 " Stefan Brüns
2018-01-01 1:24 ` [PATCH v4 " Stefan Brüns
2018-01-01 9:30 ` Jonathan Cameron
2017-12-21 18:31 ` [PATCH v2 6/7] iio: adc: ina2xx: Align timestamp with conversion ready flag Stefan Brüns
2017-12-29 17:49 ` Jonathan Cameron
2017-12-21 18:31 ` [PATCH v2 7/7] iio: adc: ina2xx: Actually align the loop with the " Stefan Brüns
2017-12-29 17:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229174602.26e7d62d@archlinux \
--to=jic23@kernel.org \
--cc=afd@ti.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.purski@samsung.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox