From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <len.brown@intel.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: [RFC][PATCH v0.1 3/6] PM: EM: Add special case to em_dev_register_perf_domain()
Date: Fri, 08 Nov 2024 17:38:11 +0100 [thread overview]
Message-ID: <2017201.usQuhbGJ8B@rjwysocki.net> (raw)
In-Reply-To: <3607404.iIbC2pHGDl@rjwysocki.net>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Allow em_dev_register_perf_domain() to register a cost-only stub
perf domain with one-element states table if the .active_power()
callback is not provided.
Subsequently, this will be used by the intel_pstate driver to register
stub perf domains for CPUs on hybrid systems.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
kernel/power/energy_model.c | 26 +++++++++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
Index: linux-pm/kernel/power/energy_model.c
===================================================================
--- linux-pm.orig/kernel/power/energy_model.c
+++ linux-pm/kernel/power/energy_model.c
@@ -426,9 +426,11 @@ static int em_create_pd(struct device *d
if (!em_table)
goto free_pd;
- ret = em_create_perf_table(dev, pd, em_table->state, cb, flags);
- if (ret)
- goto free_pd_table;
+ if (cb->active_power) {
+ ret = em_create_perf_table(dev, pd, em_table->state, cb, flags);
+ if (ret)
+ goto free_pd_table;
+ }
ret = em_compute_costs(dev, em_table->state, cb, nr_states, flags);
if (ret)
@@ -561,11 +563,20 @@ int em_dev_register_perf_domain(struct d
{
unsigned long cap, prev_cap = 0;
unsigned long flags = 0;
+ bool stub_pd = false;
int cpu, ret;
if (!dev || !nr_states || !cb)
return -EINVAL;
+ if (!cb->active_power) {
+ if (!cb->get_cost || nr_states > 1 || microwatts)
+ return -EINVAL;
+
+ /* Special case: a stub perf domain. */
+ stub_pd = true;
+ }
+
/*
* Use a mutex to serialize the registration of performance domains and
* let the driver-defined callback functions sleep.
@@ -590,6 +601,15 @@ int em_dev_register_perf_domain(struct d
ret = -EEXIST;
goto unlock;
}
+
+ /*
+ * The capacity need not be the same for all CPUs in a
+ * stub perf domain, so long as the average cost of
+ * running on each of them is approximately the same.
+ */
+ if (stub_pd)
+ continue;
+
/*
* All CPUs of a domain must have the same
* micro-architecture since they all share the same
next prev parent reply other threads:[~2024-11-08 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 16:09 [RFC][PATCH v0.1 0/6] cpufreq: intel_pstate: Enable EAS on hybrid platforms without SMT Rafael J. Wysocki
2024-11-08 16:36 ` [RFC][PATCH v0.1 1/6] PM: EM: Move perf rebuilding function from schedutil to EM Rafael J. Wysocki
2024-11-08 16:37 ` [RFC][PATCH v0.1 2/6] PM: EM: Call em_compute_costs() from em_create_perf_table() Rafael J. Wysocki
2024-11-12 8:21 ` Dietmar Eggemann
2024-11-08 16:38 ` Rafael J. Wysocki [this message]
2024-11-12 8:21 ` [RFC][PATCH v0.1 3/6] PM: EM: Add special case to em_dev_register_perf_domain() Dietmar Eggemann
2024-11-18 15:24 ` Hongyan Xia
2024-11-19 13:51 ` Rafael J. Wysocki
2024-11-08 16:40 ` [RFC][PATCH v0.1 4/6] PM: EM: Introduce em_dev_expand_perf_domain() Rafael J. Wysocki
2024-11-08 16:41 ` [RFC][PATCH v0.1 5/6] sched/topology: Allow .setpolicy() cpufreq drivers to enable EAS Rafael J. Wysocki
2024-11-11 11:54 ` Christian Loehle
2024-11-11 13:54 ` Rafael J. Wysocki
2024-11-19 15:13 ` Vincent Guittot
2024-11-19 17:37 ` Peter Zijlstra
2024-11-19 19:28 ` Rafael J. Wysocki
2024-11-08 16:46 ` [RFC][PATCH v0.1 6/6] cpufreq: intel_pstate: Add basic EAS support on hybrid platforms Rafael J. Wysocki
2024-11-12 8:21 ` Dietmar Eggemann
2024-11-19 14:38 ` Rafael J. Wysocki
2024-11-18 16:34 ` Pierre Gondois
2024-11-19 17:20 ` Rafael J. Wysocki
2024-12-16 15:32 ` Pierre Gondois
2024-12-16 17:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2017201.usQuhbGJ8B@rjwysocki.net \
--to=rjw@rjwysocki.net \
--cc=dietmar.eggemann@arm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox