From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linus.walleij@linaro.org, mail@maciej.szmigiero.name,
linux@roeck-us.net, linux-gpio@vger.kernel.org,
linux-iio@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v2 1/5] iio: Change ISA_BUS_API dependency to selection
Date: Mon, 1 Jan 2018 09:55:25 +0000 [thread overview]
Message-ID: <20180101095525.0de5021a@archlinux> (raw)
In-Reply-To: <84517171cdb142f3f04b45de6ef8daf13442a866.1514578085.git.vilhelm.gray@gmail.com>
On Fri, 29 Dec 2017 15:13:19 -0500
William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus
> driver. The ISA bus driver does not perform any hardware interaction,
> and is instead just a thin layer of software abstraction to eliminate
> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API
> has no dependencies and does not jeopardize the integrity of the system
> when enabled, drivers should select it when the ISA bus driver
> functionality is needed.
>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/adc/Kconfig | 3 ++-
> drivers/iio/counter/Kconfig | 3 ++-
> drivers/iio/dac/Kconfig | 3 ++-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index ef86296b8b0d..7c00e5858693 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -658,7 +658,8 @@ config STM32_ADC
>
> config STX104
> tristate "Apex Embedded Systems STX104 driver"
> - depends on PC104 && X86 && ISA_BUS_API
> + depends on PC104 && X86
> + select ISA_BUS_API
> select GPIOLIB
> help
> Say yes here to build support for the Apex Embedded Systems STX104
> diff --git a/drivers/iio/counter/Kconfig b/drivers/iio/counter/Kconfig
> index 474e1ac4e7c0..bf1e559ad7cd 100644
> --- a/drivers/iio/counter/Kconfig
> +++ b/drivers/iio/counter/Kconfig
> @@ -7,7 +7,8 @@ menu "Counters"
>
> config 104_QUAD_8
> tristate "ACCES 104-QUAD-8 driver"
> - depends on PC104 && X86 && ISA_BUS_API
> + depends on PC104 && X86
> + select ISA_BUS_API
> help
> Say yes here to build support for the ACCES 104-QUAD-8 quadrature
> encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).
> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> index 965d5c0d2468..76db0768e454 100644
> --- a/drivers/iio/dac/Kconfig
> +++ b/drivers/iio/dac/Kconfig
> @@ -195,7 +195,8 @@ config AD7303
>
> config CIO_DAC
> tristate "Measurement Computing CIO-DAC IIO driver"
> - depends on X86 && ISA_BUS_API
> + depends on X86 && (ISA_BUS || PC104)
> + select ISA_BUS_API
> help
> Say yes here to build support for the Measurement Computing CIO-DAC
> analog output device family (CIO-DAC16, CIO-DAC08, PC104-DAC06). The
next prev parent reply other threads:[~2018-01-01 9:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 20:13 [PATCH v2 0/5] Change ISA_BUS_API dependency to selection William Breathitt Gray
2017-12-29 20:13 ` [PATCH v2 1/5] iio: " William Breathitt Gray
2018-01-01 9:55 ` Jonathan Cameron [this message]
2018-02-22 15:14 ` Linus Walleij
2017-12-29 20:13 ` [PATCH v2 2/5] watchdog: " William Breathitt Gray
2018-02-22 15:15 ` Linus Walleij
2017-12-29 20:13 ` [PATCH v2 3/5] gpio: " William Breathitt Gray
2018-02-22 15:16 ` Linus Walleij
2018-02-22 20:30 ` William Breathitt Gray
2018-02-22 20:44 ` Maciej S. Szmigiero
2018-02-23 13:50 ` Maciej S. Szmigiero
2018-02-23 14:09 ` Linus Walleij
2017-12-29 20:14 ` [PATCH v2 4/5] isa: Remove ISA_BUS_API selection for ISA_BUS William Breathitt Gray
2018-02-22 15:18 ` Linus Walleij
2017-12-29 20:14 ` [PATCH v2 5/5] pc104: Add EXPERT dependency for PC104 Kconfig option William Breathitt Gray
2018-02-22 15:20 ` Linus Walleij
2018-02-22 20:45 ` William Breathitt Gray
2018-01-02 9:29 ` [PATCH v2 0/5] Change ISA_BUS_API dependency to selection Linus Walleij
2018-01-31 2:22 ` William Breathitt Gray
2018-02-19 14:47 ` Maciej S. Szmigiero
2018-02-22 15:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180101095525.0de5021a@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mail@maciej.szmigiero.name \
--cc=pmeerw@pmeerw.net \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).