From: James Hogan <james.hogan@mips.com>
To: Mathieu Malaterre <malat@debian.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Marcin Nowakowski <marcin.nowakowski@mips.com>,
David Daney <david.daney@cavium.com>,
Goran Ferenc <goran.ferenc@imgtec.com>,
Miodrag Dinic <miodrag.dinic@mips.com>,
<linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] MIPS: add declaration for function `memory_region_available`
Date: Tue, 2 Jan 2018 09:51:26 +0000 [thread overview]
Message-ID: <20180102095125.GO27409@jhogan-linux.mipstec.com> (raw)
In-Reply-To: <20171226113717.15074-1-malat@debian.org>
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
On Tue, Dec 26, 2017 at 12:37:13PM +0100, Mathieu Malaterre wrote:
> Fix non-fatal warning:
>
> arch/mips/kernel/setup.c:158:13: warning: no previous prototype for ‘memory_region_available’ [-Wmissing-prototypes]
> bool __init memory_region_available(phys_addr_t start, phys_addr_t size)
> ^~~~~~~~~~~~~~~~~~~~~~~
It only seems to be referenced from that one file, so making it static
and __maybe_unused to handle the configs it isn't used would probably be
better.
Thanks
James
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> arch/mips/include/asm/bootinfo.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
> index e26a093bb17a..32e3c9a2c5a0 100644
> --- a/arch/mips/include/asm/bootinfo.h
> +++ b/arch/mips/include/asm/bootinfo.h
> @@ -108,6 +108,7 @@ extern struct boot_mem_map boot_mem_map;
>
> extern void add_memory_region(phys_addr_t start, phys_addr_t size, long type);
> extern void detect_memory_region(phys_addr_t start, phys_addr_t sz_min, phys_addr_t sz_max);
> +extern bool memory_region_available(phys_addr_t start, phys_addr_t size);
>
> extern void prom_init(void);
> extern void prom_free_prom_memory(void);
> --
> 2.11.0
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-02 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 11:37 [PATCH 1/2] MIPS: add declaration for function `memory_region_available` Mathieu Malaterre
2017-12-26 11:37 ` [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0 Mathieu Malaterre
2018-01-02 9:31 ` James Hogan
2018-01-02 18:55 ` Mathieu Malaterre
2018-02-14 10:35 ` Mathieu Malaterre
2018-02-14 13:59 ` James Hogan
2018-01-02 18:53 ` [PATCH v2 " Mathieu Malaterre
2018-01-02 9:51 ` James Hogan [this message]
2018-01-02 18:52 ` [PATCH v2 1/2] MIPS: Make declaration for function `memory_region_available` static Mathieu Malaterre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102095125.GO27409@jhogan-linux.mipstec.com \
--to=james.hogan@mips.com \
--cc=david.daney@cavium.com \
--cc=goran.ferenc@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=malat@debian.org \
--cc=marcin.nowakowski@mips.com \
--cc=miodrag.dinic@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox