From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbeABQit (ORCPT + 1 other); Tue, 2 Jan 2018 11:38:49 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:33572 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbeABQir (ORCPT ); Tue, 2 Jan 2018 11:38:47 -0500 X-Google-Smtp-Source: ACJfBosOsfsEZGzHLqX7MGWIg0NoJ2Itd3+kaQf8OCKYz+fBXRqyQ+wBv+Sfb7IvdkmG8TEiZPOhOg== Date: Tue, 2 Jan 2018 08:38:43 -0800 From: Tejun Heo To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-ide@vger.kernel.org Subject: Re: [PATCH] ata: ahci_brcm: Avoid clobbering SATA_TOP_CTRL_BUS_CTRL Message-ID: <20180102163843.GG3668920@devbig577.frc2.facebook.com> References: <20171222194331.6330-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171222194331.6330-1-f.fainelli@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Dec 22, 2017 at 11:43:08AM -0800, Florian Fainelli wrote: > We are doing a blind write to SATA_TOP_CTRL_BUS_CTRL to set the system > endian, but in doing so, we are also overwriting other bits, such as the > SATA_SCB_BURST_SIZE and SATA_FIFO_SIZE bits, which impact performance. > Do a read/modify/write so we keep the default values. > > While we are at it, we also greatly simplify the logic and just leave > the NSP specific bit settings, instead of having a completely different > sequence. > > Signed-off-by: Florian Fainelli Applied to libata/for-4.16. Thanks. -- tejun