public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, James Ettle <james@ettle.org.uk>,
	linux-integrity@vger.kernel.org, azhar.shaikh@intel.com,
	linux-kernel@vger.kernel.org, james.l.morris@oracle.com
Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system
Date: Tue, 2 Jan 2018 21:53:56 +0100	[thread overview]
Message-ID: <20180102205356.GA24307@amd> (raw)
In-Reply-To: <1d724655-b0cc-b1bd-c771-839a04a74000@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]



> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index e7bd2e750f69..0858c08b3b89 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -688,7 +688,7 @@ static void tpm_tis_clkrun_enable(struct tpm_chip *chip, bool value)
>  	struct tpm_tis_data *data = dev_get_drvdata(&chip->dev);
>  	u32 clkrun_val;
>  
> -	if (!IS_ENABLED(CONFIG_X86) || !is_bsw())
> +	if (!IS_ENABLED(TCG_TIS_ENABLE_CLKRUN_QUIRK) || !is_bsw())

Missing CONFIG_?
								pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-01-02 20:54 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 19:37 [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system James Ettle
2017-12-12 11:38 ` Javier Martinez Canillas
2017-12-12 18:57   ` Jason Gunthorpe
2017-12-12 19:12     ` Javier Martinez Canillas
2017-12-12 21:17   ` James Ettle
2017-12-14 19:08     ` Javier Martinez Canillas
2017-12-14 19:10       ` Jason Gunthorpe
2017-12-15 14:56         ` Jarkko Sakkinen
2017-12-15 17:38           ` Jason Gunthorpe
2017-12-16 17:01             ` Jarkko Sakkinen
2017-12-16 20:59               ` Javier Martinez Canillas
2017-12-18 11:11                 ` Javier Martinez Canillas
2018-01-02 20:53                   ` Pavel Machek [this message]
2017-12-18 12:22               ` Javier Martinez Canillas
2017-12-18 12:29                 ` Javier Martinez Canillas
2017-12-18 17:55                   ` Jason Gunthorpe
2017-12-18 19:29                     ` Javier Martinez Canillas
2017-12-18 19:34                       ` Shaikh, Azhar
2017-12-18 20:04                         ` Shaikh, Azhar
2017-12-18 20:19                         ` Jason Gunthorpe
2017-12-18 23:34                           ` Javier Martinez Canillas
2017-12-19  2:08                             ` Jason Gunthorpe
2017-12-19 13:10                             ` Jarkko Sakkinen
2017-12-19 13:12                               ` Javier Martinez Canillas
2017-12-19 13:04                           ` Jarkko Sakkinen
2017-12-19 20:20                             ` Jason Gunthorpe
2017-12-18 23:06                         ` Javier Martinez Canillas
2017-12-18 20:17                       ` Jason Gunthorpe
2017-12-19 13:02                     ` Jarkko Sakkinen
2017-12-18 18:26                   ` James Ettle
2017-12-18 19:34                     ` Javier Martinez Canillas
2017-12-19 13:00                     ` Jarkko Sakkinen
2017-12-19 13:18                       ` James Ettle
2017-12-22 18:30                         ` Jarkko Sakkinen
2017-12-19 12:59                 ` Jarkko Sakkinen
2017-12-19 13:10                   ` Javier Martinez Canillas
2017-12-19 21:08                 ` [PATCH 1/1] tpm: only attempt to disable the LPC CLKRUN if is already kbuild test robot
2017-12-14 11:21 ` [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system Jarkko Sakkinen
2017-12-14 12:05   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180102205356.GA24307@amd \
    --to=pavel@ucw.cz \
    --cc=azhar.shaikh@intel.com \
    --cc=james.l.morris@oracle.com \
    --cc=james@ettle.org.uk \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox