From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbeACBOC (ORCPT + 1 other); Tue, 2 Jan 2018 20:14:02 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:41138 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037AbeACBOA (ORCPT ); Tue, 2 Jan 2018 20:14:00 -0500 Date: Tue, 2 Jan 2018 17:13:52 -0800 From: Darren Hart To: Joe Perches Cc: SF Markus Elfring , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, Andy Shevchenko , Andy Shevchenko , Henrique de Moraes Holschuh , LKML , kernel-janitors@vger.kernel.org Subject: Re: platform/x86/thinkpad_acpi: Adjustments for four function implementations Message-ID: <20180103011352.GE24794@fury> References: <81459d11-693a-eb51-9173-9c189677f422@users.sourceforge.net> <20171223014033.jx7fzu7uzjfbzyca@khazad-dum.debian.net> <80ae8328-5851-01b0-cb31-474f7baf1686@users.sourceforge.net> <20180103001034.GC24794@fury> <1514940583.31497.4.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514940583.31497.4.camel@perches.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 02, 2018 at 04:49:43PM -0800, Joe Perches wrote: > On Tue, 2018-01-02 at 16:10 -0800, Darren Hart wrote: > > > > Leave those pr_ messages alone, please, > [] > > Andy and Henrique raised a few reasons why these patches should not be > > accepted: > > > > 1. This is init code (so any space savings is short lived) > > Not exactly true. > > The object code itself is short lived, but the > string constant of the format is not as it is > placed in const and not discarded. Thanks for the clarification, appreciate it. I hadn't looked into it in enough detail previously. -- Darren Hart VMware Open Source Technology Center