* [PATCH -next] soundwire: Fix typo in return value check of sdw_read()
@ 2018-01-02 4:08 Wei Yongjun
2018-01-02 20:00 ` [alsa-devel] " Pierre-Louis Bossart
2018-01-03 3:24 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-01-02 4:08 UTC (permalink / raw)
To: Vinod Koul, Sanyog Kale; +Cc: Wei Yongjun, alsa-devel, linux-kernel
Fix the typo, 'status' should be instead of 'status2'.
Fixes: b0a9c37b0178 ("soundwire: Add slave status handling")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/soundwire/bus.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 4c34519..266d2b3 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -671,8 +671,8 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status)
status2 = sdw_read(slave, SDW_DP0_INT);
if (status2 < 0) {
dev_err(slave->bus->dev,
- "SDW_DP0_INT read failed:%d", status);
- return status;
+ "SDW_DP0_INT read failed:%d", status2);
+ return status2;
}
status &= status2;
@@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave,
/* Read DPN interrupt again */
status2 = sdw_read(slave, addr);
- if (status < 0) {
+ if (status2 < 0) {
dev_err(slave->bus->dev,
- "SDW_DPN_INT read failed:%d", status);
- return status;
+ "SDW_DPN_INT read failed:%d", status2);
+ return status2;
}
status &= status2;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH -next] soundwire: Fix typo in return value check of sdw_read()
2018-01-02 4:08 [PATCH -next] soundwire: Fix typo in return value check of sdw_read() Wei Yongjun
@ 2018-01-02 20:00 ` Pierre-Louis Bossart
2018-01-03 3:24 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2018-01-02 20:00 UTC (permalink / raw)
To: Wei Yongjun, Vinod Koul, Sanyog Kale; +Cc: alsa-devel, linux-kernel
On 1/1/18 10:08 PM, Wei Yongjun wrote:
> Fix the typo, 'status' should be instead of 'status2'.
well spotted, thanks!
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Fixes: b0a9c37b0178 ("soundwire: Add slave status handling")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/soundwire/bus.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 4c34519..266d2b3 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -671,8 +671,8 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status)
> status2 = sdw_read(slave, SDW_DP0_INT);
> if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DP0_INT read failed:%d", status);
> - return status;
> + "SDW_DP0_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> @@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave,
>
> /* Read DPN interrupt again */
> status2 = sdw_read(slave, addr);
> - if (status < 0) {
> + if (status2 < 0) {
> dev_err(slave->bus->dev,
> - "SDW_DPN_INT read failed:%d", status);
> - return status;
> + "SDW_DPN_INT read failed:%d", status2);
> + return status2;
> }
> status &= status2;
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] soundwire: Fix typo in return value check of sdw_read()
2018-01-02 4:08 [PATCH -next] soundwire: Fix typo in return value check of sdw_read() Wei Yongjun
2018-01-02 20:00 ` [alsa-devel] " Pierre-Louis Bossart
@ 2018-01-03 3:24 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2018-01-03 3:24 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Sanyog Kale, alsa-devel, linux-kernel
On Tue, Jan 02, 2018 at 04:08:19AM +0000, Wei Yongjun wrote:
> Fix the typo, 'status' should be instead of 'status2'.
>
> Fixes: b0a9c37b0178 ("soundwire: Add slave status handling")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-03 3:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 4:08 [PATCH -next] soundwire: Fix typo in return value check of sdw_read() Wei Yongjun
2018-01-02 20:00 ` [alsa-devel] " Pierre-Louis Bossart
2018-01-03 3:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox