From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751589AbeACIiZ (ORCPT + 1 other); Wed, 3 Jan 2018 03:38:25 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:57350 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbeACIiX (ORCPT ); Wed, 3 Jan 2018 03:38:23 -0500 Date: Wed, 3 Jan 2018 09:38:11 +0100 From: Antoine Tenart To: Colin King Cc: Antoine Tenart , Herbert Xu , "David S . Miller" , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][crypto-next] crypto: inside-secure - make function safexcel_try_push_requests static Message-ID: <20180103083811.GA21727@kwain> References: <20180102143410.13261-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180102143410.13261-1-colin.king@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Colin, On Tue, Jan 02, 2018 at 02:34:10PM +0000, Colin King wrote: > > /* Called with ring's lock taken */ > -int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, int ring, > - int reqs) > +static int safexcel_try_push_requests(struct safexcel_crypto_priv *priv, > + int ring, int reqs) Alignment should match open parenthesis, one space is missing. Otherwise, looks good to me. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com