From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBovyw7J0AZ+TQYlqFrgW8jZduXqcG2wQ4I847bUyVf5PN3TPCkVll/Jnr4AExKd6XnZEUNKY ARC-Seal: i=1; a=rsa-sha256; t=1515067793; cv=none; d=google.com; s=arc-20160816; b=YRmai3GP7w/gfsIheMWYGrE6SJRQizPFuXIUTPWGwT/HkzKJzCEk3nMZu1T2GYXLUA cS82kyEbSQAl0ar5NnTUxhKLLNyJPuZvH+mJtfZgSoo+XFTegeQ7bi7qMp4Md7X7umrF IGvxF6nAXZubD3cT3c1cUo2iBa1F+uNngAaza8N8I0QuyXbBgZ2aFUkwEt+0+024z4SR 7W/Sxg6oRwvmEWjJczc1Ge7J951QWIIyNmvW4a19nmAygUaaMBJf2KITpuGAx+/gSmy8 z1rGFESbzeGfJJzlEedX5K7C0MrLb4tCfWCT7fi/QvUjxqQS4+sWV8gIPB0ra5Bk66Z2 FBGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=YxBJVXIk4+mOqQYUZiPQf70GFF46JcqCLqmC6pxKR4c=; b=G8GXcWWoC5bc8lfGzYB7nL90iORVKP0Ip2uye+f8EhfhUZdmTENyMegGrAch+WqrOE 7fxr8UYb6Tt2/ya4fuBvMvgN29hwEPuRlL6EF8PvpG1EquVmXxjc9onaFyCOoW6jZTYv nsxq9rPxTNIk29eKsVO9CLShyvRmXuAXu1IhaweN7G8rfxlogoCbCFu8x3S7Q+C0ilnR 4sliS8O2AXQ8vQlAsy1HsvMx9jQa4L3CCip/h0JVIGNMHm4aqEzpp61B0NistR4bG/YG qHa2hjrS1fMpUeheb+vV0lZNewqCJa4AoqJJBp/cPQ7jPACX4svb9/Po++FrRGvBBbrW KKGg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Lutomirski , Alexander Tsoy , Josh Poimboeuf , Andy Lutomirski , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , =?UTF-8?q?Toralf=20F=C3=B6rster?= , Ingo Molnar Subject: [PATCH 4.14 06/14] x86/dumpstack: Print registers for first stack frame Date: Thu, 4 Jan 2018 13:09:23 +0100 Message-Id: <20180104120917.878100029@linuxfoundation.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180104120917.043667757@linuxfoundation.org> References: <20180104120917.043667757@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1588663726653268872?= X-GMAIL-MSGID: =?utf-8?q?1588663726653268872?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josh Poimboeuf commit 3ffdeb1a02be3086f1411a15c5b9c481fa28e21f upstream. In the stack dump code, if the frame after the starting pt_regs is also a regs frame, the registers don't get printed. Fix that. Reported-by: Andy Lutomirski Tested-by: Alexander Tsoy Signed-off-by: Josh Poimboeuf Cc: Andy Lutomirski Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Toralf Förster Fixes: 3b3fa11bc700 ("x86/dumpstack: Print any pt_regs found on the stack") Link: http://lkml.kernel.org/r/396f84491d2f0ef64eda4217a2165f5712f6a115.1514736742.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/dumpstack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -115,6 +115,7 @@ void show_trace_log_lvl(struct task_stru unwind_start(&state, task, regs, stack); stack = stack ? : get_stack_pointer(task, regs); + regs = unwind_get_entry_regs(&state, &partial); /* * Iterate through the stacks, starting with the current stack pointer. @@ -132,7 +133,7 @@ void show_trace_log_lvl(struct task_stru * - hardirq stack * - entry stack */ - for (regs = NULL; stack; stack = PTR_ALIGN(stack_info.next_sp, sizeof(long))) { + for ( ; stack; stack = PTR_ALIGN(stack_info.next_sp, sizeof(long))) { const char *stack_name; if (get_stack_info(stack, task, &stack_info, &visit_mask)) {