From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbeADS0B (ORCPT + 1 other); Thu, 4 Jan 2018 13:26:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:48616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbeADS0A (ORCPT ); Thu, 4 Jan 2018 13:26:00 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E99DB21869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 4 Jan 2018 15:25:54 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix compiling error in libunwind x86 Message-ID: <20180104182554.GD14721@kernel.org> References: <20171206015040.114574-1-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171206015040.114574-1-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Em Wed, Dec 06, 2017 at 01:50:40AM +0000, Wang Nan escreveu: > Fix a compiling error: > > ... > CC util/libunwind/x86_32.o > In file included from util/libunwind/x86_32.c:33:0: > util/libunwind/../../arch/x86/util/unwind-libunwind.c: In function 'libunwind__x86_reg_id': > util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: error: 'EINVAL' undeclared (first use in this function) > return -EINVAL; > ^ > util/libunwind/../../arch/x86/util/unwind-libunwind.c:110:11: note: each undeclared identifier is reported only once for each function it appears in > mv: cannot stat 'util/libunwind/.x86_32.o.tmp': No such file or directory > make[4]: *** [util/libunwind/x86_32.o] Error 1 > make[3]: *** [util] Error 2 > make[2]: *** [libperf-in.o] Error 2 > make[1]: *** [sub-make] Error 2 > make: *** [all] Error 2 > > It happens when libunwind-x86 feature is detected. Thanks, simple enough, applied. - Arnaldo > Signed-off-by: Wang Nan > --- > tools/perf/arch/x86/util/unwind-libunwind.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c > index 9c917f8..05920e3 100644 > --- a/tools/perf/arch/x86/util/unwind-libunwind.c > +++ b/tools/perf/arch/x86/util/unwind-libunwind.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > > -#ifndef REMOTE_UNWIND_LIBUNWIND > #include > +#ifndef REMOTE_UNWIND_LIBUNWIND > #include > #include "perf_regs.h" > #include "../../util/unwind.h" > -- > 2.10.1