From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbeADSpa (ORCPT + 1 other); Thu, 4 Jan 2018 13:45:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:51270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbeADSp3 (ORCPT ); Thu, 4 Jan 2018 13:45:29 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BC852190C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 4 Jan 2018 15:45:24 -0300 From: Arnaldo Carvalho de Melo To: Jin Yao Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v2] perf report: Fix a no annotate browser displayed issue Message-ID: <20180104184524.GA20593@kernel.org> References: <1514284963-18587-1-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514284963-18587-1-git-send-email-yao.jin@linux.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Em Tue, Dec 26, 2017 at 06:42:43PM +0800, Jin Yao escreveu: > v2: > -- > Fix a crash bug when perform 'perf report --stdio'. > > The reason is that we init the symbol annotation only in browser mode, > it doesn't allocate/init resources for stdio mode. > > So now in hist_iter__branch_callback(), it will return directly if it's > not in browser mode. Thanks, tested and applied! - Arnaldo