Re: [PATCH 6/7] x86/spec_ctrl: Add sysctl knobs to enable/disable SPEC_CTRL feature

Thomas Gleixner
2018-01-05T13:48:30Z

On Thu, 4 Jan 2018, Dave Hansen wrote:
> On 01/04/2018 10:33 AM, Borislav Petkov wrote:
> >> 2. At run time
> >> echo 0 > /sys/kernel/debug/ibrs_enabled will turn off IBRS
> >> echo 1 > /sys/kernel/debug/ibrs_enabled will turn on IBRS in kernel
> >> echo 2 > /sys/kernel/debug/ibrs_enabled will turn on IBRS in both userspace and kernel
> > I am not sure that tristate is really needed. What's wrong with on/off
> > only?
>
> Lots of things:
>
> Distros have the tri-state already deployed.

Which is the least relevant argument. Distros have shipped a lot of crap.

> Paranoid people want "IBRS always" aka "ibrs 2".
> Future CPUs may have cheap-enough IBRS to not be worth switching it.

So again, as I said to David in the retpoline thread.

1) Start off with a CPU bug flag which describes the attack mode.

2) Have feature flags, which denote the mitigation mode

3) Have proper command line switching similar to pti

4) Keep the sysctl stuff separate

Thanks,

tglx