Re: [PATCH 6/7] x86/spec_ctrl: Add sysctl knobs to enable/disable SPEC_CTRL feature

Borislav Petkov
2018-01-04T18:55:17Z

On Thu, Jan 04, 2018 at 07:38:26PM +0100, Andrea Arcangeli wrote:
> Consolidating in arch/x86/kernel/spec_ctrl.c would allow removing that
> export.
>
> Here I've got:
>
> static DEFINE_MUTEX(spec_ctrl_mutex);

Yap.

> Turning this off at any time is very easy, making reptoline runtime
> disabled is more difficult.

So dwmw2 is doing alternatives. Seems workable to me.

Also, you don't want to slap all those different settings in front of
the user and then expect her to do an informed choice in all cases.

So it should be a very simple first set of choices what to set and then
add more only when really needed and when it really makes sense.

IMO.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.