Re: [PATCH 2/7] x86/enter: MACROS to set/clear IBRS

Thomas Gleixner
2018-01-05T13:19:20Z

On Thu, 4 Jan 2018, Tim Chen wrote:
> On 01/04/2018 02:16 PM, Peter Zijlstra wrote:
> >> + movl \save_reg, %eax
> >> + wrmsr
> >> +10:
> >> +.endm
> >
> > Should not all those 10 things look like .Ldone_\@ or something ?
> >
>
> They are removed in patch 6 with .Ldone_\@

So we need to develop speculative review capabilities from now on?

Please get your act together and fold stuff to the right place upfront, so
we can concentrate on the actual implementation review.

Thanks,

tglx