From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
x86@kernel.org, douly.fnst@cn.fujitsu.com, rostedt@goodmis.org,
jgross@suse.com, peterz@infradead.org, uobergfe@redhat.com,
joro@8bytes.org
Subject: [RESEND PATCH 1/3] x86/apic: Set up through LAPIC on boot CPU's LINT0 if ioapic is disabled
Date: Fri, 5 Jan 2018 12:37:50 +0800 [thread overview]
Message-ID: <20180105043750.GJ7235@x1> (raw)
In-Reply-To: <1515123732-28908-1-git-send-email-bhe@redhat.com>
Kdump kernel will become very slow if 'noapic' is specified in kernel
command line. Normal kernel doesn't have this issue.
This is because the legacy irq mode is disabled in crashed kernel before
jump jump to kdump kernel since commit 522e664644 ("x86/apic: Disable I/O
APIC before shutdown of the local APIC") is merged. While in normal kernel,
the legacy irq mode has been set in BIOS.
So we need set the delivery mode AS ExtINT for LVT0 of boot CPU's LAPIC
explicitly if IO-APIC is disabled, to set up through-local-APIC.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
arch/x86/kernel/apic/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 880441f24146..7e613fb90630 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1521,7 +1521,7 @@ void setup_local_APIC(void)
* TODO: set up through-local-APIC from through-I/O-APIC? --macro
*/
value = apic_read(APIC_LVT0) & APIC_LVT_MASKED;
- if (!cpu && (pic_mode || !value)) {
+ if (!cpu && (pic_mode || !value || skip_ioapic_setup)) {
value = APIC_DM_EXTINT;
apic_printk(APIC_VERBOSE, "enabled ExtINT on CPU#%d\n", cpu);
} else {
--
2.5.5
next prev parent reply other threads:[~2018-01-05 4:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 3:42 [RESEND PATCH 0/3] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He
2018-01-05 4:37 ` Baoquan He [this message]
2018-01-17 9:27 ` [RESEND PATCH 1/3] x86/apic: Set up through LAPIC on boot CPU's LINT0 if ioapic is disabled Baoquan He
2018-01-05 4:38 ` [RESEND PATCH 2/3] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He
2018-01-17 9:30 ` Baoquan He
2018-01-17 9:47 ` Dou Liyang
2018-01-17 10:08 ` Baoquan He
2018-01-19 6:24 ` Dou Liyang
2018-01-05 4:39 ` [RESEND PATCH 3/3] x86/apic: Clean up the names of legacy irq mode setting related functions Baoquan He
2018-01-17 9:31 ` Baoquan He
2018-01-19 6:42 ` Dou Liyang
2018-01-19 7:21 ` Baoquan He
2018-01-19 8:06 ` Dou Liyang
2018-01-19 9:22 ` Baoquan He
2018-01-25 2:48 ` Baoquan He
2018-01-11 2:05 ` [RESEND PATCH 0/3] x86/apic/kexec: Enable legacy irq mode before jump to kexec/kdump kernel Baoquan He
2018-01-11 18:28 ` Eric W. Biederman
2018-01-17 9:42 ` Baoquan He
2018-01-11 19:05 ` Eric W. Biederman
2018-01-12 6:28 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105043750.GJ7235@x1 \
--to=bhe@redhat.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=uobergfe@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox