[PATCH net-next 07/20] net: hns3: Mask the packet statistics query when NIC is down

Peng Li
2018-01-05T09:51:25Z

From: Jian Shen <shenjian15@huawei.com>

Update the HNS3_NIC_STATE_DOWN bit when NIC state changes.
When NIC is down, mask the packet statistics for querying
with ifconfig command. It's a common practice.

Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 79c5daa..a8e4406 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -247,6 +247,8 @@ static int hns3_nic_net_up(struct net_device *netdev)
if (ret)
goto out_start_err;

+ clear_bit(HNS3_NIC_STATE_DOWN, &priv->state);
+
return 0;

out_start_err:
@@ -286,6 +288,9 @@ static void hns3_nic_net_down(struct net_device *netdev)
const struct hnae3_ae_ops *ops;
int i;

+ if (test_and_set_bit(HNS3_NIC_STATE_DOWN, &priv->state))
+ return;
+
/* stop ae_dev */
ops = priv->ae_handle->ae_algo->ops;
if (ops->stop)
@@ -1135,6 +1140,9 @@ static int hns3_nic_set_features(struct net_device *netdev,
u64 tx_pkts = 0;
u64 rx_pkts = 0;

+ if (test_bit(HNS3_NIC_STATE_DOWN, &priv->state))
+ return;
+
handle->ae_algo->ops->update_stats(handle, &netdev->stats);

for (idx = 0; idx < queue_num; idx++) {
--
1.9.1