Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

David Miller
2018-01-09T01:39:19Z

From: Jakub Kicinski <kubakici@wp.pl>
Date: Mon, 8 Jan 2018 12:04:31 -0800

> Ugh, I so didn't review this in time :( I think there is a consensus
> that we should avoid duplicating standard stats in ethtool. Especially
> those old ones. Like "collisions", I assume this is a modern NIC, are
> collisions still a thing?

There is no standard way to get per-queue values, and ethtool stats are
how pretty much every driver provides it.