From: Vinod Koul <vinod.koul@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
ALSA <alsa-devel@alsa-project.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Sudheer Papothi <spapothi@codeaurora.org>,
Takashi <tiwai@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
plai@codeaurora.org, LKML <linux-kernel@vger.kernel.org>,
patches.audio@intel.com, srinivas.kandagatla@linaro.org,
Sagar Dharia <sdharia@codeaurora.org>,
alan@linux.intel.com
Subject: Re: [alsa-devel] [PATCH v6 07/14] regmap: Add SoundWire bus support
Date: Sat, 6 Jan 2018 11:42:23 +0530 [thread overview]
Message-ID: <20180106061223.GP18649@localhost> (raw)
In-Reply-To: <98480de5-cd6b-845f-df1d-c9593596055f@linux.intel.com>
On Fri, Jan 05, 2018 at 11:22:15AM -0600, Pierre-Louis Bossart wrote:
> On 1/5/18 11:04 AM, Mark Brown wrote:
> >On Thu, Dec 14, 2017 at 11:19:38AM +0530, Vinod Koul wrote:
> >
> >>+ /* SoundWire register address are contiguous */
> >>+ if (config->reg_stride != 0)
> >>+ return -ENOTSUPP;
> >
> >That doesn't mean the chip hasn't decided not to use half the addresses
> >for some reason - this isn't something the bus should be enforcing.
>
> Good point. The contiguous requirement is valid only for normative
> registers, where the device has no choice but to follow the standard. For
> the imp-def part where regmap would typically be used, then indeed there is
> no restriction, chip implementers can do whatever they want.
> I have a vague memory that regmap was only intended to be used for this
> latter case, but Vinod and team should clarify this.
Right now it is used by codec for imp-def area. We do plan to add for all
registers eventually
Thanks
--
~Vinod
next prev parent reply other threads:[~2018-01-06 6:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 5:49 [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem Vinod Koul
2017-12-14 5:49 ` [PATCH v6 01/14] Documentation: Add SoundWire summary Vinod Koul
2017-12-14 5:49 ` [PATCH v6 02/14] soundwire: Add SoundWire bus type Vinod Koul
2017-12-14 5:49 ` [PATCH v6 03/14] soundwire: Add Master registration Vinod Koul
2017-12-14 5:49 ` [PATCH v6 04/14] soundwire: Add MIPI DisCo property helpers Vinod Koul
2017-12-14 5:49 ` [PATCH v6 05/14] soundwire: Add SoundWire MIPI defined registers Vinod Koul
2017-12-14 5:49 ` [PATCH v6 06/14] soundwire: Add IO transfer Vinod Koul
2017-12-14 5:49 ` [PATCH v6 07/14] regmap: Add SoundWire bus support Vinod Koul
2018-01-05 17:04 ` Mark Brown
2018-01-05 17:22 ` [alsa-devel] " Pierre-Louis Bossart
2018-01-06 6:12 ` Vinod Koul [this message]
2018-01-06 6:11 ` Vinod Koul
2018-01-05 17:05 ` Mark Brown
2018-01-06 6:13 ` [alsa-devel] " Vinod Koul
2017-12-14 5:49 ` [PATCH v6 08/14] soundwire: Add Slave status handling helpers Vinod Koul
2017-12-14 5:49 ` [PATCH v6 09/14] soundwire: Add slave status handling Vinod Koul
2017-12-14 5:49 ` [PATCH v6 10/14] soundwire: cdns: Add cadence library Vinod Koul
2017-12-14 5:49 ` [PATCH v6 11/14] soundwire: cdns: Add sdw_master_ops and IO transfer support Vinod Koul
2017-12-14 5:49 ` [PATCH v6 12/14] soundwire: intel: Add Intel Master driver Vinod Koul
2017-12-14 5:49 ` [PATCH v6 13/14] soundwire: intel: Add Intel init module Vinod Koul
2017-12-14 5:49 ` [PATCH v6 14/14] MAINTAINERS: Add SoundWire entry Vinod Koul
2017-12-14 7:35 ` [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem Greg Kroah-Hartman
2017-12-14 10:53 ` Vinod Koul
2017-12-14 12:49 ` Greg Kroah-Hartman
2017-12-14 13:18 ` Vinod Koul
2017-12-14 15:09 ` Mark Brown
2017-12-19 10:33 ` Greg Kroah-Hartman
2017-12-14 9:02 ` Philippe Ombredanne
2017-12-14 10:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106061223.GP18649@localhost \
--to=vinod.koul@intel.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=plai@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).