From: Jonathan Cameron <jic23@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/12] iio: common: ssp_sensors: account for const type of of_device_id.data
Date: Sat, 6 Jan 2018 12:23:06 +0000 [thread overview]
Message-ID: <20180106122306.44085d25@archlinux> (raw)
In-Reply-To: <1514899688-27844-12-git-send-email-Julia.Lawall@lip6.fr>
On Tue, 2 Jan 2018 14:28:07 +0100
Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> This driver creates a number of const structures that it stores in the
> data field of an of_device_id array.
>
> Add const to the declaration of the location that receives a value
> from the data field to ensure that the compiler will continue to check
> that the value is not modified and remove the const-dropping cast on
> the access to the data field.
>
> Done using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks. Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to play with it.
Jonathan
>
> ---
> drivers/iio/common/ssp_sensors/ssp.h | 2 +-
> drivers/iio/common/ssp_sensors/ssp_dev.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff -u -p a/drivers/iio/common/ssp_sensors/ssp.h b/drivers/iio/common/ssp_sensors/ssp.h
> --- a/drivers/iio/common/ssp_sensors/ssp.h
> +++ b/drivers/iio/common/ssp_sensors/ssp.h
> @@ -188,7 +188,7 @@ struct ssp_sensorhub_info {
> */
> struct ssp_data {
> struct spi_device *spi;
> - struct ssp_sensorhub_info *sensorhub_info;
> + const struct ssp_sensorhub_info *sensorhub_info;
> struct timer_list wdt_timer;
> struct work_struct work_wdt;
> struct delayed_work work_refresh;
> diff -u -p a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -486,7 +486,7 @@ static struct ssp_data *ssp_parse_dt(str
> if (!match)
> goto err_mcu_reset_gpio;
>
> - data->sensorhub_info = (struct ssp_sensorhub_info *)match->data;
> + data->sensorhub_info = match->data;
>
> dev_set_drvdata(dev, data);
>
>
next prev parent reply other threads:[~2018-01-06 12:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 13:27 [PATCH 00/12] account for const type of of_device_id.data Julia Lawall
2018-01-02 13:27 ` [PATCH 01/12] PM / AVS: rockchip-io: " Julia Lawall
2018-01-02 13:27 ` [PATCH 02/12] pinctrl: at91-pio4: " Julia Lawall
2018-01-03 7:58 ` Linus Walleij
2018-01-02 13:27 ` [PATCH 03/12] spi: sirf: " Julia Lawall
2018-01-03 12:15 ` Applied "spi: sirf: account for const type of of_device_id.data" to the spi tree Mark Brown
2018-01-03 12:22 ` Mark Brown
2018-01-02 13:28 ` [PATCH 04/12] PCI: qcom: account for const type of of_device_id.data Julia Lawall
2018-01-03 12:22 ` Lorenzo Pieralisi
2018-01-03 12:38 ` Stanimir Varbanov
2018-01-03 12:38 ` Julia Lawall
2018-01-03 18:23 ` Lorenzo Pieralisi
2018-01-02 13:28 ` [PATCH 05/12] pinctrl: armada-37xx: " Julia Lawall
2018-01-02 15:36 ` Gregory CLEMENT
2018-01-03 8:03 ` Linus Walleij
2018-01-02 13:28 ` [PATCH 06/12] power: supply: " Julia Lawall
2018-01-09 16:22 ` Sebastian Reichel
2018-01-02 13:28 ` [PATCH 07/12] i2c: rk3x: " Julia Lawall
2018-01-15 18:24 ` Wolfram Sang
2018-01-17 11:00 ` Heiko Stuebner
2018-01-17 23:12 ` Wolfram Sang
2018-01-02 13:28 ` [PATCH 08/12] pinctrl: axp209: " Julia Lawall
2018-01-03 7:59 ` Linus Walleij
2018-01-02 13:28 ` [PATCH 09/12] mtd: fsl-quadspi: " Julia Lawall
2018-01-07 18:08 ` Cyrille Pitchen
2018-01-02 13:28 ` [PATCH 10/12] spi: spi-fsl-dspi: " Julia Lawall
2018-01-03 12:22 ` Applied "spi: spi-fsl-dspi: account for const type of of_device_id.data" to the spi tree Mark Brown
2018-01-02 13:28 ` [PATCH 11/12] iio: common: ssp_sensors: account for const type of of_device_id.data Julia Lawall
2018-01-06 12:23 ` Jonathan Cameron [this message]
2018-01-02 13:28 ` [PATCH 12/12] power: reset: " Julia Lawall
2018-01-05 13:24 ` Alexandre Belloni
2018-01-09 16:22 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180106122306.44085d25@archlinux \
--to=jic23@kernel.org \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox