* metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' @ 2018-01-07 1:07 Guenter Roeck 2018-01-07 8:50 ` Michal Hocko 0 siblings, 1 reply; 4+ messages in thread From: Guenter Roeck @ 2018-01-07 1:07 UTC (permalink / raw) To: Michal Hocko; +Cc: James Hogan, linux-metag, linux-kernel The following build error is seen when building metag:meta2_defconfig or metag:tz1090_defconfig. arch/metag/kernel/process.c: In function '__metag_elf_map': arch/metag/kernel/process.c:421: error: 'tsk' undeclared Bisect results attached. Guenter --- # bad: [990b6a07d18cb30a66db3d18ab7d953806237e6a] Add linux-next specific files for 20180105 # good: [30a7acd573899fd8b8ac39236eff6468b195ac7d] Linux 4.15-rc6 git bisect start 'HEAD' 'v4.15-rc6' # good: [4411e1d8bfc93afafc74548669d772750432e0b7] Merge remote-tracking branch 'crypto/master' git bisect good 4411e1d8bfc93afafc74548669d772750432e0b7 # good: [fcdad798ac60727fc0a90c36815d19b1629e45a4] Merge remote-tracking branch 'devicetree/for-next' git bisect good fcdad798ac60727fc0a90c36815d19b1629e45a4 # good: [fe14c29e6d6772e5fc7bb8dc7a7568ce6a887a8e] Merge remote-tracking branch 'staging/staging-next' git bisect good fe14c29e6d6772e5fc7bb8dc7a7568ce6a887a8e # good: [b8be2479df7dda35d0d73fafa3f1d9c95c6a89b6] Merge remote-tracking branch 'gpio/for-next' git bisect good b8be2479df7dda35d0d73fafa3f1d9c95c6a89b6 # bad: [76248405844bf17c0620aea2f0e5bb751fc680b3] lib/stackdepot.c: use a non-instrumented version of memcmp() git bisect bad 76248405844bf17c0620aea2f0e5bb751fc680b3 # good: [b852120f0251533f414c35396f151d2ddd4d3bde] mm: get 7% more pages in a pagevec git bisect good b852120f0251533f414c35396f151d2ddd4d3bde # bad: [2b7030305a472bd15268818282e37818eec2386b] userfaultfd: convert to use anon_inode_getfd() git bisect bad 2b7030305a472bd15268818282e37818eec2386b # bad: [b7ebb7ed4b3c8ed9fac1ccb0f32ff3e94e697176] mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks git bisect bad b7ebb7ed4b3c8ed9fac1ccb0f32ff3e94e697176 # good: [d37faf4a02f9bda96fe637e50fdf880e789f8468] mm: do not lose dirty and accessed bits in pmdp_invalidate() git bisect good d37faf4a02f9bda96fe637e50fdf880e789f8468 # bad: [b8093f6e4db920936a51e161c2c208e7327c073f] mm: don't use the same value for MAP_FIXED_NOREPLACE and MAP_SYNC git bisect bad b8093f6e4db920936a51e161c2c208e7327c073f # good: [d3d42f1481dd877a66577c4c406c18d386ea55f0] mm: introduce MAP_FIXED_NOREPLACE git bisect good d3d42f1481dd877a66577c4c406c18d386ea55f0 # bad: [7847968573148a5645d53a73ea26c0f4b168d7bb] fs, elf: drop MAP_FIXED usage from elf_map git bisect bad 7847968573148a5645d53a73ea26c0f4b168d7bb # good: [cea5c2e4296daaf5d9eec338382a85159d1d4a7f] mm-introduce-map_fixed_safe-fix git bisect good cea5c2e4296daaf5d9eec338382a85159d1d4a7f # first bad commit: [7847968573148a5645d53a73ea26c0f4b168d7bb] fs, elf: drop MAP_FIXED usage from elf_map ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' 2018-01-07 1:07 metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' Guenter Roeck @ 2018-01-07 8:50 ` Michal Hocko 2018-01-08 4:12 ` Guenter Roeck 0 siblings, 1 reply; 4+ messages in thread From: Michal Hocko @ 2018-01-07 8:50 UTC (permalink / raw) To: Guenter Roeck, Andrew Morton; +Cc: James Hogan, linux-metag, linux-kernel On Sat 06-01-18 17:07:33, Guenter Roeck wrote: > The following build error is seen when building metag:meta2_defconfig > or metag:tz1090_defconfig. > > arch/metag/kernel/process.c: In function '__metag_elf_map': > arch/metag/kernel/process.c:421: error: 'tsk' undeclared Sorry about that and thanks for your report. The following should fix the issue. Andrew, could you fold it to the original patch please? --- >From 64da2e0c134ecf3936a4c36b949bcf2cdc98977e Mon Sep 17 00:00:00 2001 From: Michal Hocko <mhocko@suse.com> Date: Sun, 7 Jan 2018 09:47:41 +0100 Subject: [PATCH] fs-elf-drop-map_fixed-usage-from-elf_map-fix-fix The following build error is seen when building metag:meta2_defconfig or metag:tz1090_defconfig. arch/metag/kernel/process.c: In function '__metag_elf_map': arch/metag/kernel/process.c:421: error: 'tsk' undeclared Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Michal Hocko <mhocko@suse.com> --- arch/metag/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c index 9e007195038d..0cca2c95a091 100644 --- a/arch/metag/kernel/process.c +++ b/arch/metag/kernel/process.c @@ -419,7 +419,7 @@ unsigned long __metag_elf_map(struct file *filep, unsigned long addr, if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n", - task_pid_nr(current), tsk->comm, (void *)addr); + task_pid_nr(current), current->comm, (void *)addr); if (!BAD_ADDR(map_addr) && tcm_tag != TCM_INVALID_TAG) { struct tcm_allocation *tcm; -- 2.15.1 -- Michal Hocko SUSE Labs ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' 2018-01-07 8:50 ` Michal Hocko @ 2018-01-08 4:12 ` Guenter Roeck 2018-01-09 11:39 ` James Hogan 0 siblings, 1 reply; 4+ messages in thread From: Guenter Roeck @ 2018-01-08 4:12 UTC (permalink / raw) To: Michal Hocko; +Cc: Andrew Morton, James Hogan, linux-metag, linux-kernel On Sun, Jan 07, 2018 at 09:50:31AM +0100, Michal Hocko wrote: > On Sat 06-01-18 17:07:33, Guenter Roeck wrote: > > The following build error is seen when building metag:meta2_defconfig > > or metag:tz1090_defconfig. > > > > arch/metag/kernel/process.c: In function '__metag_elf_map': > > arch/metag/kernel/process.c:421: error: 'tsk' undeclared > > Sorry about that and thanks for your report. The following should fix > the issue. Andrew, could you fold it to the original patch please? > --- > From 64da2e0c134ecf3936a4c36b949bcf2cdc98977e Mon Sep 17 00:00:00 2001 > From: Michal Hocko <mhocko@suse.com> > Date: Sun, 7 Jan 2018 09:47:41 +0100 > Subject: [PATCH] fs-elf-drop-map_fixed-usage-from-elf_map-fix-fix > > The following build error is seen when building metag:meta2_defconfig > or metag:tz1090_defconfig. > > arch/metag/kernel/process.c: In function '__metag_elf_map': > arch/metag/kernel/process.c:421: error: 'tsk' undeclared > > Reported-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Michal Hocko <mhocko@suse.com> Compiled and booted with qemu. Tested-by: Guenter Roeck <linux@roeck-us.net> Guenter > --- > arch/metag/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c > index 9e007195038d..0cca2c95a091 100644 > --- a/arch/metag/kernel/process.c > +++ b/arch/metag/kernel/process.c > @@ -419,7 +419,7 @@ unsigned long __metag_elf_map(struct file *filep, unsigned long addr, > > if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr)) > pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n", > - task_pid_nr(current), tsk->comm, (void *)addr); > + task_pid_nr(current), current->comm, (void *)addr); > > if (!BAD_ADDR(map_addr) && tcm_tag != TCM_INVALID_TAG) { > struct tcm_allocation *tcm; > -- > 2.15.1 > > -- > Michal Hocko > SUSE Labs ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' 2018-01-08 4:12 ` Guenter Roeck @ 2018-01-09 11:39 ` James Hogan 0 siblings, 0 replies; 4+ messages in thread From: James Hogan @ 2018-01-09 11:39 UTC (permalink / raw) To: Guenter Roeck; +Cc: Michal Hocko, Andrew Morton, linux-metag, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1341 bytes --] On Sun, Jan 07, 2018 at 08:12:16PM -0800, Guenter Roeck wrote: > On Sun, Jan 07, 2018 at 09:50:31AM +0100, Michal Hocko wrote: > > On Sat 06-01-18 17:07:33, Guenter Roeck wrote: > > > The following build error is seen when building metag:meta2_defconfig > > > or metag:tz1090_defconfig. > > > > > > arch/metag/kernel/process.c: In function '__metag_elf_map': > > > arch/metag/kernel/process.c:421: error: 'tsk' undeclared > > > > Sorry about that and thanks for your report. The following should fix > > the issue. Andrew, could you fold it to the original patch please? > > --- > > From 64da2e0c134ecf3936a4c36b949bcf2cdc98977e Mon Sep 17 00:00:00 2001 > > From: Michal Hocko <mhocko@suse.com> > > Date: Sun, 7 Jan 2018 09:47:41 +0100 > > Subject: [PATCH] fs-elf-drop-map_fixed-usage-from-elf_map-fix-fix > > > > The following build error is seen when building metag:meta2_defconfig > > or metag:tz1090_defconfig. > > > > arch/metag/kernel/process.c: In function '__metag_elf_map': > > arch/metag/kernel/process.c:421: error: 'tsk' undeclared > > > > Reported-by: Guenter Roeck <linux@roeck-us.net> > > Signed-off-by: Michal Hocko <mhocko@suse.com> > > Compiled and booted with qemu. > > Tested-by: Guenter Roeck <linux@roeck-us.net> > > Guenter Thanks guys for catching + fixing! Cheers James [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-09 11:40 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-01-07 1:07 metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' Guenter Roeck 2018-01-07 8:50 ` Michal Hocko 2018-01-08 4:12 ` Guenter Roeck 2018-01-09 11:39 ` James Hogan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox