From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754109AbeAGQPv (ORCPT + 1 other); Sun, 7 Jan 2018 11:15:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:42256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753897AbeAGQPt (ORCPT ); Sun, 7 Jan 2018 11:15:49 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 194782075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 7 Jan 2018 16:15:45 +0000 From: Jonathan Cameron To: "Tobin C. Harding" Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] iio: add field identifier for @use_count kernel-doc Message-ID: <20180107161545.67ffed6f@archlinux> In-Reply-To: <1515275766-31302-3-git-send-email-me@tobin.cc> References: <1515275766-31302-1-git-send-email-me@tobin.cc> <1515275766-31302-3-git-send-email-me@tobin.cc> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, 7 Jan 2018 08:56:06 +1100 "Tobin C. Harding" wrote: > Kernel-doc for @use_count does not currently have a field identifier. > All the rest of the fields do. @use_count is used internally and should > not be accessed directly by the driver so it should be marked as so. > > Add [INTERN] identifier to @use_count field. > > Signed-off-by: Tobin C. Harding Applied to the togreg branch of iio.git and pushed out as testing for the autobuilder to play with it. Thanks, Jonathan > --- > include/linux/iio/trigger.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h > index 390789d43369..b19b7204ef84 100644 > --- a/include/linux/iio/trigger.h > +++ b/include/linux/iio/trigger.h > @@ -49,7 +49,7 @@ struct iio_trigger_ops { > * @dev: [DRIVER] associated device (if relevant) > * @list: [INTERN] used in maintenance of global trigger list > * @alloc_list: [DRIVER] used for driver specific trigger list > - * @use_count: use count for the trigger > + * @use_count: [INTERN] use count for the trigger. > * @subirq_chip: [INTERN] associate 'virtual' irq chip. > * @subirq_base: [INTERN] base number for irqs provided by trigger. > * @subirqs: [INTERN] information about the 'child' irqs.