From: Guenter Roeck <linux@roeck-us.net>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
James Hogan <jhogan@kernel.org>,
linux-metag@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map'
Date: Sun, 7 Jan 2018 20:12:16 -0800 [thread overview]
Message-ID: <20180108041216.GA9132@roeck-us.net> (raw)
In-Reply-To: <20180107085031.GA24862@dhcp22.suse.cz>
On Sun, Jan 07, 2018 at 09:50:31AM +0100, Michal Hocko wrote:
> On Sat 06-01-18 17:07:33, Guenter Roeck wrote:
> > The following build error is seen when building metag:meta2_defconfig
> > or metag:tz1090_defconfig.
> >
> > arch/metag/kernel/process.c: In function '__metag_elf_map':
> > arch/metag/kernel/process.c:421: error: 'tsk' undeclared
>
> Sorry about that and thanks for your report. The following should fix
> the issue. Andrew, could you fold it to the original patch please?
> ---
> From 64da2e0c134ecf3936a4c36b949bcf2cdc98977e Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.com>
> Date: Sun, 7 Jan 2018 09:47:41 +0100
> Subject: [PATCH] fs-elf-drop-map_fixed-usage-from-elf_map-fix-fix
>
> The following build error is seen when building metag:meta2_defconfig
> or metag:tz1090_defconfig.
>
> arch/metag/kernel/process.c: In function '__metag_elf_map':
> arch/metag/kernel/process.c:421: error: 'tsk' undeclared
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Compiled and booted with qemu.
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
> ---
> arch/metag/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 9e007195038d..0cca2c95a091 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -419,7 +419,7 @@ unsigned long __metag_elf_map(struct file *filep, unsigned long addr,
>
> if ((type & MAP_FIXED_NOREPLACE) && BAD_ADDR(map_addr))
> pr_info("%d (%s): Uhuuh, elf segment at %p requested but the memory is mapped already\n",
> - task_pid_nr(current), tsk->comm, (void *)addr);
> + task_pid_nr(current), current->comm, (void *)addr);
>
> if (!BAD_ADDR(map_addr) && tcm_tag != TCM_INVALID_TAG) {
> struct tcm_allocation *tcm;
> --
> 2.15.1
>
> --
> Michal Hocko
> SUSE Labs
next prev parent reply other threads:[~2018-01-08 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 1:07 metag build error in -next due to 'fs, elf: drop MAP_FIXED usage from elf_map' Guenter Roeck
2018-01-07 8:50 ` Michal Hocko
2018-01-08 4:12 ` Guenter Roeck [this message]
2018-01-09 11:39 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108041216.GA9132@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox