From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757020AbeAHLyW (ORCPT + 1 other); Mon, 8 Jan 2018 06:54:22 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:55996 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756531AbeAHLyV (ORCPT ); Mon, 8 Jan 2018 06:54:21 -0500 Date: Mon, 8 Jan 2018 14:48:43 +0300 From: Dan Carpenter To: George Edward Bulmer Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, jic23@kernel.org Subject: Re: [PATCH] staging: iio: light: Add breaks to lengthy lines Message-ID: <20180108114843.burtlxsfarp3uqlp@mwanda> References: <20180107150801.21617-1-gebulmer@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180107150801.21617-1-gebulmer@googlemail.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8767 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=956 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801080173 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, Jan 07, 2018 at 03:08:01PM +0000, George Edward Bulmer wrote: > This fixes three instances of checkpatch warning: > WARNING: line over 80 characters > > Signed-off-by: George Edward Bulmer > --- > drivers/staging/iio/light/tsl2x7x.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c > index 42ed9c015aaf..126e11530ce0 100644 > --- a/drivers/staging/iio/light/tsl2x7x.c > +++ b/drivers/staging/iio/light/tsl2x7x.c > @@ -1441,7 +1441,8 @@ static irqreturn_t tsl2x7x_event_handler(int irq, void *private) > > static struct attribute *tsl2x7x_ALS_device_attrs[] = { > &dev_attr_in_illuminance0_calibscale_available.attr, > - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr, > + &iio_const_attr_in_illuminance0_integration_time_available > + .dev_attr.attr, Ugh. No. The original was better. regards, dan carpenter