public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
	jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn,
	xiaolong.ye@intel.com, Liu Wei <liu.wei8186@zte.com.cn>
Subject: Re: [RFC PATCH v2] workqueue: Introduce a way to set percpu worker_pool's scheduler
Date: Mon, 8 Jan 2018 06:29:06 -0800	[thread overview]
Message-ID: <20180108142906.GR3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1514343341-30389-1-git-send-email-wen.yang99@zte.com.cn>

Hello,

On Wed, Dec 27, 2017 at 10:55:41AM +0800, Wen Yang wrote:
> @@ -144,6 +145,11 @@ struct workqueue_attrs {
>  	 * doesn't participate in pool hash calculations or equality comparisons.
>  	 */
>  	bool no_numa;
> +
> +	/**
> +	 * @sched_attr: set kworker's scheduler
> +	 */
> +	struct sched_attr sched_attr;
>  };

It's added as a part of workqueue_attrs but implemented separately.
Can you please do the following instead?

* Add scheduler type to wq_attrs so that unbound workqueues can be
  configured.  Also, we don't need both prio and nice, right?

* Rename system_wq's wq->name from "events" to "system_percpu", and
  similarly for the similarly named workqueues.

* Enable wq_attrs (only the applicable part should show up in the
  interface) for system_percpu and system_percpu_highpri, and use that
  to change the attributes of the percpu pools.

Thanks.

-- 
tejun

      reply	other threads:[~2018-01-08 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-27  2:55 [RFC PATCH v2] workqueue: Introduce a way to set percpu worker_pool's scheduler Wen Yang
2018-01-08 14:29 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108142906.GR3668920@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=jiang.biao2@zte.com.cn \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liu.wei8186@zte.com.cn \
    --cc=wen.yang99@zte.com.cn \
    --cc=xiaolong.ye@intel.com \
    --cc=zhong.weidong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox