From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756789AbeAHO3L (ORCPT + 1 other); Mon, 8 Jan 2018 09:29:11 -0500 Received: from mail-qk0-f170.google.com ([209.85.220.170]:34208 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406AbeAHO3J (ORCPT ); Mon, 8 Jan 2018 09:29:09 -0500 X-Google-Smtp-Source: ACJfBovJwHMNEnfbr+IzrrE3yd2W/rf4qHQSKyYcXTLFwL4iWM5aWGnmEtj+q7UeO5UIb+OTGTBR8A== Date: Mon, 8 Jan 2018 06:29:06 -0800 From: Tejun Heo To: Wen Yang Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn, xiaolong.ye@intel.com, Liu Wei Subject: Re: [RFC PATCH v2] workqueue: Introduce a way to set percpu worker_pool's scheduler Message-ID: <20180108142906.GR3668920@devbig577.frc2.facebook.com> References: <1514343341-30389-1-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514343341-30389-1-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hello, On Wed, Dec 27, 2017 at 10:55:41AM +0800, Wen Yang wrote: > @@ -144,6 +145,11 @@ struct workqueue_attrs { > * doesn't participate in pool hash calculations or equality comparisons. > */ > bool no_numa; > + > + /** > + * @sched_attr: set kworker's scheduler > + */ > + struct sched_attr sched_attr; > }; It's added as a part of workqueue_attrs but implemented separately. Can you please do the following instead? * Add scheduler type to wq_attrs so that unbound workqueues can be configured. Also, we don't need both prio and nice, right? * Rename system_wq's wq->name from "events" to "system_percpu", and similarly for the similarly named workqueues. * Enable wq_attrs (only the applicable part should show up in the interface) for system_percpu and system_percpu_highpri, and use that to change the attributes of the percpu pools. Thanks. -- tejun