From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933692AbeAHOqC (ORCPT + 1 other); Mon, 8 Jan 2018 09:46:02 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:46030 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933678AbeAHOp6 (ORCPT ); Mon, 8 Jan 2018 09:45:58 -0500 X-Google-Smtp-Source: ACJfBot8Aqv/vBcxVYBfzJJuuzr0PDJaTKXwVhtT0zUjXatAZ6ovxqTMDq81Z+Gvqv3sLNdx5hMRPQ== Date: Mon, 8 Jan 2018 15:45:56 +0100 From: Johan Hovold To: Sumit Pundir Cc: johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers Message-ID: <20180108144556.GG11344@localhost> References: <1515391093-12677-1-git-send-email-pundirsumit11@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515391093-12677-1-git-send-email-pundirsumit11@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 08, 2018 at 11:28:13AM +0530, Sumit Pundir wrote: > Fixes the following coding style issue as noted by checkpatch.pl > at multiple lines: > > Comparison to NULL could be written "!token" > > Signed-off-by: Sumit Pundir Since you're not really fixing anything here, besides silencing a checkpatch suggestion when run with the --strict option (or on staging code), I suggest you reword you commit summary (Subject) to, for example: staging: greybus: camera: clean up NULL checks or similar. Note that I also added "camera" as a module prefix above. Thanks, Johan