From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933749AbeAHOv5 (ORCPT + 1 other); Mon, 8 Jan 2018 09:51:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43920 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932200AbeAHOvz (ORCPT ); Mon, 8 Jan 2018 09:51:55 -0500 Date: Mon, 8 Jan 2018 15:51:57 +0100 From: Greg Kroah-Hartman To: NeilBrown Cc: Oleg Drokin , Andreas Dilger , James Simmons , lkml , lustre Subject: Re: [PATCH 03/15] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc. Message-ID: <20180108145157.GA32570@kroah.com> References: <151355781721.6200.2136335532722530242.stgit@noble> <151355799030.6200.8100283223734974485.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <151355799030.6200.8100283223734974485.stgit@noble> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Dec 18, 2017 at 11:46:30AM +1100, NeilBrown wrote: > All usages of the form > LIBCFS_ALLOC(variable, sizeof(variable)) > or > LIBCFS_ALLOC(variable, sizeof(variable's-type)) > > are changed to > variable = kzalloc(sizeof(...), GFP_NOFS); > > Similarly, all > LIBCFS_FREE(variable, sizeof(variable)) > become > kfree(variable); > > None of these need the vmalloc option, or any of the other minor > benefits of LIBCFS_ALLOC(). > > Signed-off-by: NeilBrown As this broke the kbuild system, I'll stop here in this patch series. Can you please fix it up, rebase and resend the remaining ones in this series? thanks, greg k-h