From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934002AbeAHPCi (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 10:02:38 -0500
Received: from mail.kernel.org ([198.145.29.99]:45982 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932121AbeAHPCh (ORCPT <rfc822;Linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 10:02:37 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 163D021726
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Mon, 8 Jan 2018 12:02:35 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v7 5/6] perf report: support time percent and multiple
 time ranges
Message-ID: <20180108150235.GG25476@kernel.org>
References: <1512738826-2628-1-git-send-email-yao.jin@linux.intel.com>
 <1512738826-2628-6-git-send-email-yao.jin@linux.intel.com>
 <20180108145336.GF25476@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180108145336.GF25476@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Em Mon, Jan 08, 2018 at 11:53:36AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Dec 08, 2017 at 09:13:45PM +0800, Jin Yao escreveu:
> > perf report has a --time option to limit the time range of output.
> > It only supports absolute time.
> > 
> > Now this option is extended to support multiple time ranges and
> > support the percent of time.
> > 
> > For example:
> > 
> > 1. Select the first and second 10% time slices
> > perf report --time 10%/1,10%/2
> > 
> > 2. Select from 0% to 10% and 30% to 40% slices
> > perf report --time 0%-10%,30%-40%

So now it works, but we need to improve the error messages, i.e. if one
does:

   perf report --time 10%

should this be equivalent to:

   perf report --time 10%/1

?

Or at least say something like:

   "percent slices need an index to specify which one is wanted"

when you notice a % in the --time string, etc.

Consider these for follow up patches.

- Arnaldo