From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756801AbeAHPF7 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 10:05:59 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:50806 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755864AbeAHPF6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 10:05:58 -0500
Date: Mon, 8 Jan 2018 16:06:00 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: NeilBrown <neilb@suse.com>, Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        James Simmons <jsimmons@infradead.org>,
        lkml <linux-kernel@vger.kernel.org>,
        lustre <lustre-devel@lists.lustre.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH 3/4] staging: lustre: lnet: convert selftest to use
 workqueues
Message-ID: <20180108150600.GA19387@kroah.com>
References: <151356013394.15912.9645528414310488005.stgit@noble>
 <151356031919.15912.12406337913485020577.stgit@noble>
 <20180108144558.GA6826@kroah.com>
 <20180108145527.GT3668920@devbig577.frc2.facebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180108145527.GT3668920@devbig577.frc2.facebook.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Mon, Jan 08, 2018 at 06:55:27AM -0800, Tejun Heo wrote:
> Hello, Greg.
> 
> On Mon, Jan 08, 2018 at 03:45:58PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 18, 2017 at 12:25:19PM +1100, NeilBrown wrote:
> > > Instead of the cfs workitem library, use workqueues.
> > > 
> > > As lnet wants to provide a cpu mask of allowed cpus, it
> > > needs to be a WQ_UNBOUND work queue so that tasks can
> > > run on cpus other than where they were submitted.
> > 
> > This patch doesn't apply to my tree :(
> > 
> > > apply_workqueue_atts needs to be exported for lustre to use it.
> > 
> > That feels really odd, why is lustre so "special" that the normal
> > workqueue api doesn't work properly for it?
> > 
> > I've dropped this, and the next patch, from my queue now.  Please fix up
> > and resend and justify why lustre is so odd :)
> 
> The workqueue attrs interface is relatively new and just hasn't had
> internal module users.  It's not necessarily odd to want to use them
> from modules.  I'll be happy to ack patches which add
> EXPORT_SYMBOL_GPL() on them.

Ok, Neil, can you add Tejun's ack here when you respin this?

thanks,

greg k-h