Re: [PATCH 3/4] staging: lustre: lnet: convert selftest to use workqueues

Greg Kroah-Hartman
2018-01-08T15:05:59Z

On Mon, Jan 08, 2018 at 06:55:27AM -0800, Tejun Heo wrote:
> Hello, Greg.
>
> On Mon, Jan 08, 2018 at 03:45:58PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 18, 2017 at 12:25:19PM +1100, NeilBrown wrote:
> > > Instead of the cfs workitem library, use workqueues.
> > >
> > > As lnet wants to provide a cpu mask of allowed cpus, it
> > > needs to be a WQ_UNBOUND work queue so that tasks can
> > > run on cpus other than where they were submitted.
> >
> > This patch doesn't apply to my tree :(
> >
> > > apply_workqueue_atts needs to be exported for lustre to use it.
> >
> > That feels really odd, why is lustre so "special" that the normal
> > workqueue api doesn't work properly for it?
> >
> > I've dropped this, and the next patch, from my queue now. Please fix up
> > and resend and justify why lustre is so odd :)
>
> The workqueue attrs interface is relatively new and just hasn't had
> internal module users. It's not necessarily odd to want to use them
> from modules. I'll be happy to ack patches which add
> EXPORT_SYMBOL_GPL() on them.

Ok, Neil, can you add Tejun's ack here when you respin this?

thanks,

greg k-h