From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933609AbeAHPRN (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 8 Jan 2018 10:17:13 -0500
Received: from mail.kernel.org ([198.145.29.99]:47056 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932826AbeAHPRM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 Jan 2018 10:17:12 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A73572075D
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Mon, 8 Jan 2018 12:17:09 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH 01/12] perf tools: Enable LIBBABELTRACE by default
Message-ID: <20180108151709.GI25476@kernel.org>
References: <20180107160356.28203-1-jolsa@kernel.org>
 <20180107160356.28203-2-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180107160356.28203-2-jolsa@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Em Sun, Jan 07, 2018 at 05:03:45PM +0100, Jiri Olsa escreveu:
> There's no reason anymore to treat babel trace in a special way,
> because a) we no longer display its state b) the needed babeltrace
> library is now out and well adopted among distros.

Humm, after I applied this I got:

[acme@jouet perf]$ perf
perf: error while loading shared libraries: libbabeltrace-ctf.so.2: cannot open shared object file: No such file or directory
[acme@jouet perf]$

So it detects it somehow, builds with it, then fails to find it in the
LD_LIBRARY_PATH somehow?

- Arnaldo
 
> Link: http://lkml.kernel.org/n/tip-n1c2a8hwtf6wlh8e0uiqn8in@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/Makefile.config | 2 +-
>  tools/perf/Makefile.perf   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index f050f38d8fa3..12dec6ea5ed2 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -780,7 +780,7 @@ else
>    NO_PERF_READ_VDSOX32 := 1
>  endif
>  
> -ifdef LIBBABELTRACE
> +ifndef NO_LIBBABELTRACE
>    $(call feature_check,libbabeltrace)
>    ifeq ($(feature-libbabeltrace), 1)
>      CFLAGS += -DHAVE_LIBBABELTRACE_SUPPORT $(LIBBABELTRACE_CFLAGS)
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 68cf1360a3f3..9fdefd748e2e 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -77,7 +77,7 @@ include ../scripts/utilities.mak
>  #
>  # Define NO_ZLIB if you do not want to support compressed kernel modules
>  #
> -# Define LIBBABELTRACE if you DO want libbabeltrace support
> +# Define NO_LIBBABELTRACE if you do not want libbabeltrace support
>  # for CTF data format.
>  #
>  # Define NO_LZMA if you do not want to support compressed (xz) kernel modules
> -- 
> 2.13.6