From: Greg KH <gregkh@linuxfoundation.org>
To: Philippe Loctaux <loctauxphilippe@gmail.com>
Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vme: vme_user: removed unnecessary parentheses
Date: Mon, 8 Jan 2018 16:39:56 +0100 [thread overview]
Message-ID: <20180108153956.GA32185@kroah.com> (raw)
In-Reply-To: <20171228221530.20565-1-loctauxphilippe@gmail.com>
On Thu, Dec 28, 2017 at 11:15:30PM +0100, Philippe Loctaux wrote:
> Removed unnecessary parentheses in the if statement.
>
> Signed-off-by: Philippe Loctaux <loctauxphilippe@gmail.com>
> ---
> drivers/staging/vme/devices/vme_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 41a5b32e0..611ea219f 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -511,7 +511,7 @@ static int vme_user_match(struct vme_dev *vdev)
> int cur_slot = vme_slot_num(vdev);
>
> for (i = 0; i < bus_num; i++)
> - if ((cur_bus == bus[i]) && (cur_slot == vdev->num))
> + if (cur_bus == bus[i] && cur_slot == vdev->num)
Ick, horrid, no, now you have to look up what the order of == vs. && is,
do you know it?
thanks,
greg k-h
prev parent reply other threads:[~2018-01-08 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 22:15 [PATCH] Staging: vme: vme_user: removed unnecessary parentheses Philippe Loctaux
2018-01-08 15:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108153956.GA32185@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loctauxphilippe@gmail.com \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox