From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933966AbeAHPjz (ORCPT + 1 other); Mon, 8 Jan 2018 10:39:55 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37092 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933818AbeAHPjy (ORCPT ); Mon, 8 Jan 2018 10:39:54 -0500 Date: Mon, 8 Jan 2018 16:39:56 +0100 From: Greg KH To: Philippe Loctaux Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: vme: vme_user: removed unnecessary parentheses Message-ID: <20180108153956.GA32185@kroah.com> References: <20171228221530.20565-1-loctauxphilippe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171228221530.20565-1-loctauxphilippe@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Dec 28, 2017 at 11:15:30PM +0100, Philippe Loctaux wrote: > Removed unnecessary parentheses in the if statement. > > Signed-off-by: Philippe Loctaux > --- > drivers/staging/vme/devices/vme_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c > index 41a5b32e0..611ea219f 100644 > --- a/drivers/staging/vme/devices/vme_user.c > +++ b/drivers/staging/vme/devices/vme_user.c > @@ -511,7 +511,7 @@ static int vme_user_match(struct vme_dev *vdev) > int cur_slot = vme_slot_num(vdev); > > for (i = 0; i < bus_num; i++) > - if ((cur_bus == bus[i]) && (cur_slot == vdev->num)) > + if (cur_bus == bus[i] && cur_slot == vdev->num) Ick, horrid, no, now you have to look up what the order of == vs. && is, do you know it? thanks, greg k-h