From: Greg KH <gregkh@linuxfoundation.org>
To: Sumit Pundir <pundirsumit11@gmail.com>
Cc: devel@driverdev.osuosl.org, forest@alittletooquiet.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6656: Fix unnecessary parantheses
Date: Mon, 8 Jan 2018 16:45:26 +0100 [thread overview]
Message-ID: <20180108154526.GB12786@kroah.com> (raw)
In-Reply-To: <1514180134-7578-1-git-send-email-pundirsumit11@gmail.com>
On Mon, Dec 25, 2017 at 11:05:34AM +0530, Sumit Pundir wrote:
> This patch fixes a few coding style issues as noted by checkpatch.pl
> related to unnecessary parantheses.
>
> This patch fixes the following checkpatch.pl warnings:
>
> WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1'
> WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4'
>
> Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
> ---
> drivers/staging/vt6656/main_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 1b51b83..c15ae72 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -266,8 +266,8 @@ static int vnt_init_registers(struct vnt_private *priv)
>
> /* load vt3266 calibration parameters in EEPROM */
> if (priv->rf_type == RF_VT3226D0) {
> - if ((priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1) &&
> - (priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4)) {
> + if (priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1 &&
> + priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4) {
No, now you have to guess if && or == or >= comes first :(
next prev parent reply other threads:[~2018-01-08 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 5:35 [PATCH] Staging: vt6656: Fix unnecessary parantheses Sumit Pundir
2018-01-08 15:45 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-22 14:23 [PATCH] Staging: vt6656: fix " Sumit Pundir
2018-01-08 15:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108154526.GB12786@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pundirsumit11@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox