From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBot8xdLDTCKAUONEo/CTuTZ0QTGtPTvxS60qVRh7N0wuc8gfLPwaktynjImt8L0uXmUr6cAy ARC-Seal: i=1; a=rsa-sha256; t=1515428489; cv=none; d=google.com; s=arc-20160816; b=IbKdYKBbOKM92lwgddQAykMUstUwDjG/S5dlkrkAHro4crTptGH8oXYb38F7atKhuy CPTgY3gy5HQnB5R3FHJx5FTlpGtHrxGs+sH7792TO7/HC6kcl+fFX1FsQrEngHa7S+7g E6BjkpumhKrKatXU0gt4d9Qng7PjrW2//YVm0PeRLbwyX6ykj9mCvihf7tfZVfgiP+Jz xjXzOxD39vPKZPYBUq18xEncX8bWqbWTILIAXxrMgIM0HH3mdXeemf0Ppuy1uRtN7ZK1 3MBHMZk6Svg95Zu4PVPF2sUtcQUULoCpxegq5jhODL0L0Fi4miXZ7MpRPAU9VzQ1Xos7 j2FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=osEn9jYG/E7+Xl9ZuRxX1QJNc9E0Cz3IgWHGofauJGM=; b=nARwtf3whecbT1fw2ibVKL1+ETPKVTexh8aTmrhfDKyMiNCSnW0nUBkqTHptN6TOC+ 1DbcRPLWUR6vBMiRf3A84oGpbG+PQIc1jIYdyoWGRbzPDR5/pGdgOGOuLJMHANO3ufbt GDpoqBRGOHjGScGK/dGcErpCLIcetPz7Awr5riuvfRwHTxFNCJmjLxJd/jVzIa58K9I5 crQFEdPI3jCXSfPdhMgcTIkzgmObFgGaBltKk0K2d4OXWRki7y1Mqg0wcW3Yj8KPoeqw rzAHf3xzK4E22XA6TgncSESGF5EQ62iIaof3DX0OlhfyHsn1Wy/ukTjAeICdOUISvckL 6QAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Hz3m2zPC; dkim=pass header.i=@codeaurora.org header.s=default header.b=C6l79tJm; spf=pass (google.com: domain of kvalo@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=kvalo@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Hz3m2zPC; dkim=pass header.i=@codeaurora.org header.s=default header.b=C6l79tJm; spf=pass (google.com: domain of kvalo@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=kvalo@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C754960346 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post From: Kalle Valo In-Reply-To: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> References: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: colin.king@canonical.com, johannes.berg@intel.com, tiwai@suse.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, andrew.zaborowski@intel.com, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180108162128.7EE8A60B1B@smtp.codeaurora.org> Date: Mon, 8 Jan 2018 16:21:28 +0000 (UTC) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1588206680152832671?= X-GMAIL-MSGID: =?utf-8?q?1589041943224817521?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Jia-Ju Bai wrote: > b43_radio_2057_init_post is not called in an interrupt handler > nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai You submitted an identical patch a week earlier: https://patchwork.kernel.org/patch/10137671/ How is this different? Also always add version number to the patch so that the maintainers can follow the changes easily: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- https://patchwork.kernel.org/patch/10137671/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches